From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbbEFIKU (ORCPT ); Wed, 6 May 2015 04:10:20 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:14472 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbbEFIKJ (ORCPT ); Wed, 6 May 2015 04:10:09 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-82-5549cc5ec3b0 Message-id: <5549CC5C.8090107@samsung.com> Date: Wed, 06 May 2015 17:10:04 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Stephen Boyd Cc: Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] clk: bindings: Fix assigned-clock-rates property name References: <1430893716-1825-1-git-send-email-k.kozlowski@samsung.com> <20150506074518.GA11126@codeaurora.org> In-reply-to: <20150506074518.GA11126@codeaurora.org> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xa7pxZzxDDebONrSYf+Qcq8XrF4YW H3vusVpc3jWHzeLphItsFj/OdLM4sHlc7utl8rhzbQ+bR9+WVYwenzfJBbBEcdmkpOZklqUW 6dslcGW0bp3HWNAmULFwyQ72BsbtvF2MnBwSAiYSZ9pmsEDYYhIX7q1n62Lk4hASWMoo8XjR CiYI5ymjxJ6PS5lBqngFtCQufHnJCGKzCKhKbDv4CSzOJmAssXn5EqBuDg5RgQiJ7hOVEOWC Ej8m3wNbICKgLvF9x0mwBcwCjYwSX2Z/AEsIC3hJHP3/kAnEFhIokDh16zfYTE6g6051nmYF sZkFbCUWvF/HAmHLS2xe85Z5AqPALCQ7ZiEpm4WkbAEj8ypG0dTS5ILipPRcQ73ixNzi0rx0 veT83E2MkID+soNx8TGrQ4wCHIxKPLwBVZ6hQqyJZcWVuYcYJTiYlUR4p7gDhXhTEiurUovy 44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbLxMEp1cAYPPP8xHXu91d3vS++IHRA sqzr6KK3Z+ruJGprnV5WziMxsYBv1+5b5+RONxwtF1p2Lf2qqo97q2jFrVazqXybX0/wF5x5 0naKx9q6SYV1+u83TLr74+sevcRt/R2n65pql68pjfFjuH5AbYe8Q4f10eKN1XzLw94keb5T W7XG5T8H60Rjp/vVSizFGYmGWsxFxYkACgKng2QCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.05.2015 16:45, Stephen Boyd wrote: > On 05/06, Krzysztof Kozlowski wrote: >> In documentation the "assigned-clock-parents" name was used when >> describing the "assigned-clock-rates" property. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > Looks right. The whole sentence could use some work though. > >> Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt >> index 06fc6d541c89..bf5b0414dc17 100644 >> --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt >> +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt >> @@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks >> and clock frequencies. Such a configuration can be specified in a device tree >> node through assigned-clocks, assigned-clock-parents and assigned-clock-rates >> properties. The assigned-clock-parents property should contain a list of parent >> -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents >> +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates >> property the list of assigned clock frequency values - corresponding to clocks > > This half-sentence: > > The assigned-clock-ratse property the list of assigned > clock frequency values > > doesn't read correctly. Maybe the whole thing should be rewritten > as: > > The assigned-clock-parents property should contain a list > of parent clocks in the form of a phandle and clock > specifier pair and the assigned-clock-rates property > should contain a list of frequencies in Hz. Both these > properties should correspond to the clocks listed in the > assigned-clocks property. Looks much better. So actually this should be yours patch now, you can add my Reported-by :). Best regards, Krzysztof