From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbbEHIxt (ORCPT ); Fri, 8 May 2015 04:53:49 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:36774 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbbEHIx3 (ORCPT ); Fri, 8 May 2015 04:53:29 -0400 Message-ID: <554C7960.4040107@linaro.org> Date: Fri, 08 May 2015 16:52:48 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Ashwin Chaugule , Sudeep Holla CC: linux acpi , "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , lkml , Al Stone , Lorenzo Pieralisi Subject: Re: [PATCH RFC 2/5] ACPI / processor: always compile perflib if CONFIG_ACPI_PROCESSOR References: <1430922690-6966-1-git-send-email-sudeep.holla@arm.com> <1430922690-6966-3-git-send-email-sudeep.holla@arm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年05月07日 02:36, Ashwin Chaugule wrote: > Hello, > > On 6 May 2015 at 10:31, Sudeep Holla wrote: >> Similar to the idle, thermal and throttling libraries, always compile >> the perflib if CONFIG_ACPI_PROCESSOR is enabled. This not only makes >> perflib alligned with other libraries but also helps in some sanity >> testing of these ACPI methods even when a particular feature is not >> enabled in the kernel configuration. >> >> Signed-off-by: Sudeep Holla >> --- >> drivers/acpi/Makefile | 2 +- >> include/acpi/processor.h | 29 ----------------------------- >> include/linux/cpufreq.h | 4 ++++ >> 3 files changed, 5 insertions(+), 30 deletions(-) >> >> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile >> index 8a063e276530..33aef9d8b260 100644 >> --- a/drivers/acpi/Makefile >> +++ b/drivers/acpi/Makefile >> @@ -84,7 +84,7 @@ obj-$(CONFIG_ACPI_BGRT) += bgrt.o >> # processor has its own "processor." module_param namespace >> processor-y := processor_driver.o processor_throttling.o >> processor-y += processor_idle.o processor_thermal.o >> -processor-$(CONFIG_CPU_FREQ) += processor_perflib.o >> +processor-y += processor_perflib.o > > I'd prefer that we create a separate kconfig option for this. (perhaps > even default it to 'y'). This library is quite specific to a certain > type of CPU performance management methods (includes _PSS and friends) > which are superseded by CPPC. The OS is not expected to support both > at runtime, so by keeping this a config option, we can then disable it > at compile time when CPPC is enabled. We could couple I agree. CPPC and _PSS are different way of controlling CPU freq, and I think _PSS may not be used on ARM. Thanks Hanjun