From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761613AbcINSRn (ORCPT ); Wed, 14 Sep 2016 14:17:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47299 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755686AbcINSRi (ORCPT ); Wed, 14 Sep 2016 14:17:38 -0400 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkpatch: Minimize checkpatch induced patches... To: Joe Perches , Andrew Morton , Andy Whitcroft References: <1473876366.32273.40.camel@perches.com> Cc: Greg KH , Jonathan Corbet , Josh Triplett , "Theodore Ts'o" , linux-kernel@vger.kernel.org From: Christian Borntraeger Date: Wed, 14 Sep 2016 20:16:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1473876366.32273.40.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16091418-0008-0000-0000-000002C512F6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16091418-0009-0000-0000-000019D54090 Message-Id: <554bcd26-f513-adf1-1a01-8b0ca9ff4aed@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-14_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609140242 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2016 08:06 PM, Joe Perches wrote: > On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: > >> This will certainly help to reduce the noise. On the other hand I remember Linus >> saying something along the line that he does not like the -f parameter (and he >> prefers to set this automatically). So while I like the approach I am not happy >> enough to ack right now - still looking for a better alternative :-/ > > Linus likely hasn't used checkpatch in a decade or so. > > Taste and judgment can't be scripted anyway. > > Let me know if you find an alternative. You know what. with some additional writing like "Existing code outside staging is not supposed to be "fixed" to match checkpatch. Please do not send checkpatch initiated patches for those files" near the newly created warn Acked-by: Christian Borntraeger Feel free to improve my sentence to something proper.