From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA6BC30FC36 for ; Sun, 1 Mar 2026 16:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772383029; cv=none; b=jSJHf4fS1t3FNc2YqYA3Kwv9jV6pqwDPeSMjZZlC5ZgmfPf7NQgQjCPpW2Hs/NxYbzTo5CSN9Lu0xWWRajKC016uBbSzuOLXCVyR5MFUMRIMlk7zA6DysqudLFFmlGI9I2bVO3CB4NxmDGJgjYtv+yuj0sBv+KUTUl978SMLQrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772383029; c=relaxed/simple; bh=oFJcuj7s/WSXgtE/fyI6JR5pN5bvxBGTF/OtY3SgvWI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fzOA6z8NSR8JCqxIOh36x1bpvm/AggmtRkaOXhAjyc87R+AD4gKKB+Af4t6zuwSiB0UhYBZzfdHD8oM5zYOmwtijrWoJMMVpUPCvm9JAwcex3FV7BeGoCkS1mvL4GFB8ZmEl8LsjNVf2M6A+8HOvCb0XLNwZJz8Lp0gOG/iqJtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kDNx6L3A; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kDNx6L3A" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-389f173b91fso57510341fa.1 for ; Sun, 01 Mar 2026 08:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772383026; x=1772987826; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=chfWZCrwegHuS+IaibQUlGs9qTPZhd3l1r8kvwtttAg=; b=kDNx6L3Ax7ZNiHAXoFgPYfjHo+XPySUCg3BzU/Idcb0hQ30z5jgwRGSxLZw8afL6iu S6IYYknitwHBxK+ML9LvAjTQkZNvIQJEXCANgJDTYkGzYvpddiwdQEa2lksrEUfDRbYa NFFaiYFp7zNr/XmfjG2OsBPNoX6hGqM0Ms3RiEc9OWu+TH/ynn3LoLdXW3FYMPp38pxF lciytcc6CVMEQh24THT8Kp0GjO09CskLCVji79wjZGRMVJwfwgDptoe5757BSXbTnH4f 6pF+GDnNcmU88wkpIp7r2x/bcfuUuqAQUOjU4eEM6ZB9VJcViho6FTWcF2o9HN6HL5J1 lIfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772383026; x=1772987826; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=chfWZCrwegHuS+IaibQUlGs9qTPZhd3l1r8kvwtttAg=; b=j08ehCWxdjOImlbiwP0LhrCQVTuc01JczUgZqS5zyAXUS2OCQTYKp/o17iC4RvMdBq wSSB/dr+PioHp/W++PErVd7GJNgsb4CfriXBd4MCm1LFQz9mJAtquvbkiqfi3bzGn1Gk vQkQAmywgRez1ImSkV6MlzxBCH9QDAQb/e2RSnocMyUf6lXXyLraXOgpKPfk771jI4Pv AkUcuo0oTL1gZJcA9JpXRmEDvnVOwKol/ZWe702xTEMRJJSv3IlX5M8QF0dWvl6cU5Pp Yo5xwRLY/j7030572re3X0DVFftRu0EJPJ7S+nkCWhHdKfXVnVBkr+v3Qexteemj2Kuk OSLA== X-Forwarded-Encrypted: i=1; AJvYcCXhvatQvOTvgGV7l8vdwjTEb5Moy2AdZHtQ0Q4UDU3ND66N+0iicRddXg9gShF9+7MLIqq3bNnjXVfKV8o=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3EC0RlyJnXxkty8Ovuos2SgTkzpYIZY/M0hlHRdvY5/47quBe NRU8pZ7xCA0J5KO/OFC5Qum5b/SCd5VBmL3J4Lvp5RqxSqnYEgFxVqQh X-Gm-Gg: ATEYQzyitsiGzD0X4v95OlwT8I1K5DDMrfv+cxLpXoWPU2Nh1ECqDe8lKkfPMhM/bft cZ7KCKMwphmnoQI/cZPscw+Ngm+qmWt0XFggPasuYOBIjx54Gmy+z8Hv0OF7suWnuy2VgFGmcax J8jxB/5vb20aUY1axo414HrtyPmVoZZEqS1Sep35Q4iuhzDx6iEeQrfVPWCXnNRG+gHiczI73fZ y++o/9pW8wNTPCtifqUOvDEgy5Lbcaj6fwik0LpxyZnYhIADZXmPeq4YRluP4Xpi8gDWE/LHJHm rZfw4aBhyQX6g9UQYo/xy8mSVJNSFzlgsWqgx1bh8jYJci8vadRAN7rpzEQayaLlYTohhsSUGDb 5PUC/8g5kIsdqTyrfxr4PesE1pVnfia1T15Uz9jIb7xhoajnEWsUNYIHM3eX6loBfmvpTqGQZ2N iULaXe4kNNvl4dOhmQEN5/ZsZ/19ekqX2RKWX04cQMYJXiD0qay4YrerZh+hvV3T8IVVYN61NWJ 5Go X-Received: by 2002:a2e:914d:0:b0:389:fb69:9e65 with SMTP id 38308e7fff4ca-389ff356058mr42360521fa.31.1772383025715; Sun, 01 Mar 2026 08:37:05 -0800 (PST) Received: from ?IPV6:2a00:1fa0:45b:6e70:24a:6543:9307:8962? ([2a00:1fa0:45b:6e70:24a:6543:9307:8962]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a115bd2384sm1095553e87.10.2026.03.01.08.37.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 08:37:05 -0800 (PST) Message-ID: <554c1dc9-cb75-4777-ad98-97243808245d@gmail.com> Date: Sun, 1 Mar 2026 19:37:02 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] USB: pxa27x_udc: check return value of clk_enable To: Zhaoyang Yu <2426767509@qq.com>, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Sergey Shtylyov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/1/26 7:23 PM, Zhaoyang Yu wrote: > clk_enable() may fail according to the API contract. > Previously, udc_enable() ignored its return value. > This patch checks the return value and logs an error > without continuing initialization if clk_enable fails. > > Signed-off-by: Zhaoyang Yu <2426767509@qq.com> > --- > drivers/usb/gadget/udc/pxa27x_udc.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c > index 897f53601b5b..69fcecaf6061 100644 > --- a/drivers/usb/gadget/udc/pxa27x_udc.c > +++ b/drivers/usb/gadget/udc/pxa27x_udc.c > @@ -1696,7 +1696,13 @@ static void udc_enable(struct pxa_udc *udc) > if (udc->enabled) > return; > > - clk_enable(udc->clk); > + int ret; Please don't declare variables amidst of a function. IIRC, the Linux coding style doesn't allow for this C++-ism... [...] MBR, Sergey