From: Tianrui Zhao <zhaotianrui@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Mark Brown <broonie@kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
Oliver Upton <oliver.upton@linux.dev>,
maobibo@loongson.cn
Subject: Re: [PATCH v4 05/29] LoongArch: KVM: Add vcpu related header files
Date: Wed, 22 Mar 2023 09:34:46 +0800 [thread overview]
Message-ID: <554dc19a-cd94-0f94-7e81-9cdc137dac7d@loongson.cn> (raw)
In-Reply-To: <75f843b2780fc3c3dcc1d0d8f78f2b955956316b.camel@xry111.site>
在 2023年03月21日 20:30, Xi Ruoyao 写道:
> On Tue, 2023-03-21 at 11:56 +0800, Tianrui Zhao wrote:
>> +/* Tracepoints for VM exits */
>> +#define kvm_trace_symbol_exit_types \
>> + ({ KVM_TRACE_EXIT_IDLE, "IDLE" }, \
>> + { KVM_TRACE_EXIT_CACHE, "CACHE" }, \
>> + { KVM_TRACE_EXIT_SIGNAL, "Signal" })
> Looks like there shouldn't be "(" and ")".
>
>> +#define kvm_trace_symbol_aux_op \
>> + ({ KVM_TRACE_AUX_RESTORE, "restore" }, \
>> + { KVM_TRACE_AUX_SAVE, "save" }, \
>> + { KVM_TRACE_AUX_ENABLE, "enable" }, \
>> + { KVM_TRACE_AUX_DISABLE, "disable" }, \
>> + { KVM_TRACE_AUX_DISCARD, "discard" })
> Likewise.
>
> See the test robot report, and https://godbolt.org/z/bE8q97z1o.
>
> The lesson: if a text book claims "you should always wrap the content of
> a macro in ( ... )", we should burn it in the fire! :)
>
Thanks, it should remove the "()" statement in the macros. The reason I
did this before because an error was triggered when I use checkpatch.py
to check it, and now I know this error can be ignored.
Thanks
Tianrui Zhao
next prev parent reply other threads:[~2023-03-22 1:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 3:56 [PATCH v4 00/29] Add KVM LoongArch support Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 01/29] LoongArch: KVM: Add kvm related header files Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 02/29] LoongArch: KVM: Implement kvm module related interface Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 03/29] LoongArch: KVM: Implement kvm hardware enable, disable interface Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 04/29] LoongArch: KVM: Implement VM related functions Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 05/29] LoongArch: KVM: Add vcpu related header files Tianrui Zhao
2023-03-21 12:30 ` Xi Ruoyao
2023-03-22 1:34 ` Tianrui Zhao [this message]
2023-03-21 3:56 ` [PATCH v4 06/29] LoongArch: KVM: Implement vcpu create and destroy interface Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 07/29] LoongArch: KVM: Implement vcpu run interface Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 08/29] LoongArch: KVM: Implement vcpu handle exit interface Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 09/29] LoongArch: KVM: Implement vcpu get, vcpu set registers Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 10/29] LoongArch: KVM: Implement vcpu ENABLE_CAP ioctl interface Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 11/29] LoongArch: KVM: Implement fpu related operations for vcpu Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 12/29] LoongArch: KVM: Implement vcpu interrupt operations Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 13/29] LoongArch: KVM: Implement misc vcpu related interfaces Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 14/29] LoongArch: KVM: Implement vcpu load and vcpu put operations Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 15/29] LoongArch: KVM: Implement vcpu status description Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 16/29] LoongArch: KVM: Implement update VM id function Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 17/29] LoongArch: KVM: Implement virtual machine tlb operations Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 18/29] LoongArch: KVM: Implement vcpu timer operations Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 19/29] LoongArch: KVM: Implement kvm mmu operations Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 20/29] LoongArch: KVM: Implement handle csr excption Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 21/29] LoongArch: KVM: Implement handle iocsr exception Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 22/29] LoongArch: KVM: Implement handle idle exception Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 23/29] LoongArch: KVM: Implement handle gspr exception Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 24/29] LoongArch: KVM: Implement handle mmio exception Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 25/29] LoongArch: KVM: Implement handle fpu exception Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 26/29] LoongArch: KVM: Implement kvm exception vector Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 27/29] LoongArch: KVM: Implement vcpu world switch Tianrui Zhao
2023-03-21 8:07 ` kernel test robot
2023-03-21 3:56 ` [PATCH v4 28/29] LoongArch: KVM: Implement probe virtualization when loongarch cpu init Tianrui Zhao
2023-03-21 3:56 ` [PATCH v4 29/29] LoongArch: KVM: Enable kvm config and add the makefile Tianrui Zhao
2023-03-21 8:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554dc19a-cd94-0f94-7e81-9cdc137dac7d@loongson.cn \
--to=zhaotianrui@loongson.cn \
--cc=alexander.deucher@amd.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®