From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEDD28C854 for ; Tue, 31 Mar 2026 10:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952161; cv=none; b=nrIkZNh27DngFeJ19qq6S2TJPFwEiZFive+OXlRm7rYwLDG4v5pfHuQ+GE3qbg8f5W9dbUliRZMYiF1wGRZKjtg82d/2Ulit3V+emlQHeeEN0a86TnEiQev3qtm+Ut8oTGDN+JvNtJtryXy17Tb5zOth0ZtPm3G3iSJUfzocJjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952161; c=relaxed/simple; bh=K+0wcCmfHut6YFXb2lwHSRx9sP1xg70q/oq95edTjUc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Ke8ZlOSpSa2hGibzKq8xu+LUp6Fg4vuZIvGemNmTThGCKFQF6lA1d1ZUxEG+5BrcvwgfDrenyQDaAnWdLmpgXegucjwc55gLIHoj8oD9L08NOIt4eB2u+pUhDQdQZQ2EjizzaMWoYHjKOgy7/XYYqMFDSyVF6VhOzbvRawmzwcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m3jiMkLr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KqK17S9k; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m3jiMkLr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KqK17S9k" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V8k3OW2049615 for ; Tue, 31 Mar 2026 10:15:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sBShzvQgF/OK4CJre7PtXkN5npZ3FfgWdgXoXo6IYrY=; b=m3jiMkLrr28ImmuC 4iDqSTMzw20VdmJ71B7burfbADJ7EsAeQvtsHM/lIgM2LKAiBMeN1XFyHCycCY4+ ggBeU2ND5XMBe8S9h4CS6wQvdP0ffVA89TWgmt+TSConh+3fcPKSqYF2b3X3PSCf nHzLCiZ/O+YYBN450rHBuAGLuqohNxB5yYPdBLfoVaBFk7n0DseaNN5DPC7ysl4Z sptpw1XqUvbqtyqaSNsHoW+hrhNEy3JUrgatVB+x2aKImCGTgsqhc6RngAJavAbB C7Fth2Sm+deG/Snn7HAp+Wwo3K5SCImSmvn9PA2ciUVYR2v2MCHb5IlV/MDS8NR5 6Cff1w== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8b1yrc5j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 10:15:58 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50917996cfaso46192951cf.0 for ; Tue, 31 Mar 2026 03:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774952158; x=1775556958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=sBShzvQgF/OK4CJre7PtXkN5npZ3FfgWdgXoXo6IYrY=; b=KqK17S9k1Bjyz3wlKUKbs2KzvBogLGV5tF4z/+XAkSaLTV88F4W4f32zgH0OMO5dD0 up58Sycb/GOcZ+8U22/5jRB5R9f2N19T7iKzleoSrIPQSuHzZ3X/wM1hOe1NF3KP/Zye FcUAveSjzMdn2GrhJ/mbcR7TEtSysXVR3z1g2wY1Z7Nwfh90KRTT4CPbjGXVSCj1h23V YLB57gokyyoMIQ6AirXaLW4QiSjdkJkPD6xE55tJfTsimYcYf1gdCoWddeEoAxcAVAiZ YoYW1vb3KsFsIT3mkl4ZGBnEQNUUV3UI/RjQ/dU08/u37ms3kCObs4ET7kImdeb58CO7 Bb0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774952158; x=1775556958; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sBShzvQgF/OK4CJre7PtXkN5npZ3FfgWdgXoXo6IYrY=; b=iTg4TEhGWrTa9Pf9Slmmblqc5LSt8xN9NR9i51PqCjLwuDhz+JRHo8SeqhaTDCM7Qc 5Rvl71cACSWFBAqnOFYCju5tTLeLasBiIskeDIFt5K1kvjbR6wy+F6cxUuPmX3AB0c5i 6Y2tI0+R+D/uDxaUL4rVgW2Xmq+TC8HSW4ALHdFNsBuZlR4bddKTtS/Zdh0Rpmd8moCH yk9v1fk2CnCo6vFyRODrz8VPf4I6G6NxSmw9HhtLtdYaR19foyGEdT5nBlaYmJOckqkX zJnoJew51SOsa5GeOjL7xGSWTeXvzBUqCGgMV1CcXlViZGYzWAeTM3y9Kzf0YG6L1Zul 2K0g== X-Forwarded-Encrypted: i=1; AJvYcCUxS38XaJpS9tx9x90jc68+SxilTO47lRkpirJkcM3VvnDh8VSPLko+W/3NEyrs+lUvMMwy2ut1z6/OUIA=@vger.kernel.org X-Gm-Message-State: AOJu0YzBnxDsCgErh0qKzLeIn6FQ9WL30Rg58SRDqgl21K6YT3AmovTD mFq/NweS3/xez/ZFC15LcF/ZBSQycmn0RhSYsKepuaqquOEWwUwxZWK6BulXPgFTgdTusgVGwD9 HM5AvfMG21Znocq13buEpHcyhlMAefmWzu5STIW0B3Vh/nN9LJJB6/3EWtYcUEeuFMrk= X-Gm-Gg: ATEYQzxqm9qw4VROJDJHU3OrOMHZ6WnkUlOv2dRX6tmvoecUZ03tGPwUBSYGp0qyMaB tbW4udPubRlh5HXraIYVUhyWd1IbEFKVSXrBG+e4ZYj0Us+85DhfP9mHj/cLZMfbVjVbAchJehL xn3HP4Y4TP8o3fobZ25DzO7ayKHvRFjZ4v5SnouEAb39WFBojcR1KCkCmh9uCuUlckznab+JPrH vpaHEXn48Ju4AORrFmLL49pMd4kJpdiGQvPF5i1Jk205eAl0ldrs//inuAh/Do7PiFKSFQWpt+i XCC8AVGOD5Pjg7UXgymhtIe8Ok38p5Ham+p+EqwI4M2m/J0AZL8pXGntQInPa+e1dJhKclxsxTW pKPaITaAK6ucEaetq2g6bGGM+hJ178UWbMQEj/8INLSuuphZvs/QZHgVKuCyEOf/6vDMc09f56O TBpEptWxvvsFRBxO52Ez9zok43MdutOv3A7BG0sSdogAO4flPz2Jjgdv2VGt1j18uLubmpHHGaM PL8cnfDNBIvFhOH X-Received: by 2002:a05:622a:4015:b0:509:1579:7c3b with SMTP id d75a77b69052e-50ba390216fmr220716261cf.51.1774952157973; Tue, 31 Mar 2026 03:15:57 -0700 (PDT) X-Received: by 2002:a05:622a:4015:b0:509:1579:7c3b with SMTP id d75a77b69052e-50ba390216fmr220715951cf.51.1774952157554; Tue, 31 Mar 2026 03:15:57 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66c07ab15basm1345132a12.17.2026.03.31.03.15.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 03:15:56 -0700 (PDT) Message-ID: <55510bea-30ff-45f2-b4c7-4a191ff214a1@oss.qualcomm.com> Date: Tue, 31 Mar 2026 12:15:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v5 0/4] platform/x86: int3472: Add support for GPIO type 0x02 (strobe) To: Sakari Ailus Cc: Marco Nenciarini , djrscally@gmail.com, ilpo.jarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260327181031.1489365-1-mnencia@kcore.it> <76baf0c3-4c1f-4169-846d-5c74dab69a18@oss.qualcomm.com> <06317144-d652-466a-86e9-da2569a1acf6@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: e915nA1-haBs6mcbqqRRPdUOKENRIMDb X-Proofpoint-ORIG-GUID: e915nA1-haBs6mcbqqRRPdUOKENRIMDb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA5OCBTYWx0ZWRfX/Xh+9gQQ64VV MUvV465ndeysHBp1Hcpa5DILeftk47gSErDacWgQIBgIrgtv62kDM5hUiHh5oCi9/PWkOb/VMsK EaWIybQMs4HNFAPeYaXEFIWNUczUmca40EE3EYlq5q8y5jZfX0+LohTZfINEJjswkcbaK1g2yFB pKJdczL79fhlRYPUE7z3KgumhsyufQSjWgd01weJkZakDfNQl8mTbjcBRM1xyvVkmrNSHdAQC/e mmH786/u7wijHb4+FolCfwj/M0OJDXkc7bSU3ezp0mu0qrcT8CWX6IIJ4VvILAmBarE2V6Yi6F2 YmYPSG0C2Th9GawbY8MbEv9U2k4mHFpuc0KOXR7MOLyBoOZ/7XIKvxidJLzcjFgFjUzGXyqno7N byrrKSBI3yDh7ibecGDTxdNw3OzTjL8vCs8uq8QhBH4W5nxbf+OLa7RkIdac1CQ3KGWPhmnNfU5 fOkEI5jwjyMJEHBruxA== X-Authority-Analysis: v=2.4 cv=aJT9aL9m c=1 sm=1 tr=0 ts=69cb9ede cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=BXj6raveOS0NqA4VA5cA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310098 Hi Sakari, On 30-Mar-26 22:21, Sakari Ailus wrote: > Hi Hans, Marco, > > On Mon, Mar 30, 2026 at 05:12:21PM +0200, johannes.goede@oss.qualcomm.com wrote: >> Hi, >> >> On 30-Mar-26 16:55, Marco Nenciarini wrote: >>> Hi Hans, >>> >>> Thank you for the detailed feedback. >>> >>>> My main remark on the current patch set is that IMHO >>>> the LED name really should be: OVTIxxxx:00::ir_flood_led >>>> since that is what it actually does, strobe is typically >>>> related to flash LEDs which despite the naming in Intel's >>>> side this is not. >>> >>> The series actually started with "ir_flood" in v1-v2. It was renamed to >>> "strobe" in v3 to match the GPIO type name used in Intel's ACPI _DSM >>> tables. But I agree with you that the userspace-visible LED name should >>> describe what the hardware actually does, not mirror an internal ACPI >>> label. I am happy to go back to "ir_flood" for the LED name. >>> >>> We could keep INT3472_GPIO_TYPE_STROBE for the define (matching the ACPI >>> type value) but pass "ir_flood" as the con_id to the LED registration, >>> so userspace sees OVTIxxxx:00::ir_flood_led. Would that work for >>> everyone? >> >> That sounds good to me. > > Seems reasonable. > >> >>>> We really need to get some input from the V4L2 maintainers >>>> here on if this is a good idea, before merging this series. >>> >>> Agreed. >>> >>>> I can even imagine >>>> a default simple mode where the v4l2-core just turns >>>> on the LED when streaming starts and off again when >>>> streaming stops (very much like the privacy LED) and >>>> then in the future maybe we can extend this, e.g. >>>> add a control on the sensor device to make this >>>> configurable ? >>> >>> That makes a lot of sense. The current series intentionally keeps things >>> minimal (just exposing the LED under /sys/class/leds with no V4L2 >>> integration), but this future direction sounds right. >>> >>> I will hold off on sending v6 until we have agreement on the naming and >>> Sakari has had a chance to weigh in. >> >> Ack, lets wait for input from Sakari here. > > I wonder if there would be any deterministic ways to find the LED device > based on the sensor. It'd probably require more information via MC / V4L2 > controls to allow that. Yes, the int3472 code adds a LED lookup table entry with the consumer- device being the sensor. So just like v4l2-subdev.c currently does: sd->privacy_led = led_get(sd->dev, "privacy"); it will also be able to do: sd->privacy_led = led_get(sd->dev, "ir_flood"); > Alternatively we could use a boolean control for this, but I think I'd > avoid adding that now and rely on LED API instead. > > Are there use cases for this LED, apart from Windows Hello? :-) As mentioned for now we could just treat it exactly the same as the privacy LED and simply turn it on while streaming inside the v4l2-core / v4l2-subdev code. This would nicely cover the face ID use-case for which Linux implementations exist to. And then later of some other use-case comes up we could make this a menu-control with on/off/auto values, defaulting to auto which would preserve the turn it on while streaming behavior. We do need to come up with something here, since use-cases like Howdy (Linux face-id) will need it. My vote goes to give it the same treatment as the privacy LED in the v4l2-core for now making things "just work". Alternatively we could document that userspace needs to find the LED and turn it on itself through the LED classdev but that will be painful for userspace to do for various reasons including classdev access requiring root rights. Regards, Hans