From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE90AC433F5 for ; Fri, 28 Jan 2022 02:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345390AbiA1Cny (ORCPT ); Thu, 27 Jan 2022 21:43:54 -0500 Received: from relay025.a.hostedemail.com ([64.99.140.25]:35611 "EHLO relay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S241696AbiA1Cnx (ORCPT ); Thu, 27 Jan 2022 21:43:53 -0500 Received: from omf17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B882420D82; Fri, 28 Jan 2022 02:43:49 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA id 8AECD1A; Fri, 28 Jan 2022 02:43:10 +0000 (UTC) Message-ID: <5554a75f65fddab4de60d61fd503fe73773dafbb.camel@perches.com> Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid From: Joe Perches To: Tom Rix , Nick Desaulniers , Finn Thain , Miguel Ojeda Cc: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com, martin.petersen@oracle.com, nathan@kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Date: Thu, 27 Jan 2022 18:43:40 -0800 In-Reply-To: References: <20220127151945.1244439-1-trix@redhat.com> <953eb015-4b78-f7b-5dc1-6491c6bf27e@linux-m68k.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: x39h7xij7ferynwq1baymdwur1t13kh4 X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 8AECD1A X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/dz/eWBoFmWNgbWpQYIec/MEbMEENQX0Y= X-HE-Tag: 1643337790-237904 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-01-27 at 16:32 -0800, Tom Rix wrote: > On 1/27/22 2:47 PM, Nick Desaulniers wrote: > > + Miguel (the clang-format maintainer), Joe (checkpatch maintainer) > > These criticisms are worth reviewing. > > > > On Thu, Jan 27, 2022 at 2:38 PM Finn Thain wrote: > > > > > > On Thu, 27 Jan 2022, trix@redhat.com wrote: > > > > > > > From: Tom Rix > > > > > > > > checkpatch reports several hundred formatting errors. Run these files > > > > through clang-format and knock off some of them. > > > > > > > That method seems like a good recipe for endless churn unless checkpatch > > > and clang-format really agree about these style rules. > > > > > > Why use checkpatch to assess code style, if we could simply diff the > > > existing source with the output from clang-format... but it seems that > > > clang-format harms readability, makes indentation errors and uses > > > inconsistent style rules. Some examples: > > Problems with clang-format should be fixed, I'll take a look. > > I was reviewing this file for another issue and could not get past how > horredously bad it was and really did not want to manually fix the 400+ > formatting errors.  I will drop this patch and use the use these files > to verify the .clang-format . I think this is more an issue with clang-format than with checkpatch. If you have specific issues with what checkpatch reports for this file (or any other file), let me know.