From: Luka Gejak <luka.gejak@linux.dev>
To: Zeshan Ahmed Nobin <zeshanahmednobin@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH RESEND rtw-next v2 1/2] wifi: rtw88: 8822c: fix out-of-bounds access in cck_pd_set
Date: Mon, 09 Nov 2026 20:24:22 +0100 [thread overview]
Message-ID: <55577FA1-C8E3-4810-800A-487C2526F9C0@linux.dev> (raw)
In-Reply-To: <20261109182001.29076-1-zeshanahmednobin@gmail.com>
Hi Zeshan,
On November 9, 2026 7:20:01 PM GMT+01:00, Zeshan Ahmed Nobin
<zeshanahmednobin@gmail.com> wrote:
>
> patch 2 is then what handles a dead chip. In v3 I'll update its
> message for that and add Cc: stable to it as well. Its code doesn't
> change; is it fine to keep your Reviewed-by on it?
Yes, that matches what I see, so please keep it.
"bw has already been checked at that point" in the message and "patch 1
returns first" in the notes won't be true any more, so those need
updating too. The forced bw test won't apply either, so maybe run the
real chip failure case again with both patches.
As far as I can see patch 1 alone would then reach that zero mask access
on PCIe, so maybe keep this order and say in the cover letter that the
two belong together.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-11-09 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 18:28 [PATCH RESEND rtw-next v2 0/2] wifi: rtw88: 8822c: check register values " Zeshan Ahmed Nobin
2026-11-08 18:28 ` [PATCH RESEND rtw-next v2 1/2] wifi: rtw88: 8822c: fix out-of-bounds access " Zeshan Ahmed Nobin
2026-11-09 6:41 ` Luka Gejak
2026-11-09 18:20 ` Zeshan Ahmed Nobin
2026-11-09 19:24 ` Luka Gejak [this message]
2026-11-08 18:28 ` [PATCH RESEND rtw-next v2 2/2] wifi: rtw88: 8822c: ignore nrx values without CCK PD registers Zeshan Ahmed Nobin
2026-11-09 6:43 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55577FA1-C8E3-4810-800A-487C2526F9C0@linux.dev \
--to=luka.gejak@linux.dev \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=zeshanahmednobin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®