From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F703A6B7C for ; Fri, 22 May 2026 14:27:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779460036; cv=none; b=iRwvuCxRkbA6IavfD8BKRnKdYCl4XT5HLKU1drDsn3Jf6R7UdcZSmoQt05YPrLFev0qAQ765i3LgNLUOnAsf3k6iR1q87cHyd77MpR5kV+CougTXevj1zL5bjSSdfhJNBXS+BDFg1SkMzdqXvEjtpJnsWYk1SmHuIewpjINenqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779460036; c=relaxed/simple; bh=+/KdWaTE6XJ5/5BpP8P+TgWyqyheMKCqLPgg79yBq/g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TEs9ZLUZD6VjwyDoUxrSio4vWeun952VMio73xyIHFkhEaYl1SEyS7+sfUPMfUr6DGhBlTqTGs7Xf7TG7CZwrhrp+rH+Y+WYYqR7QP706DQ15AT9JmYcLSKKstVMrFEaJSV0lC4LE+taFlFUb0XfKjLXcckbEvwJves2Z5aRBL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=gM18PusL; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="gM18PusL" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-43587e63a8eso4821805fac.0 for ; Fri, 22 May 2026 07:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1779460033; x=1780064833; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6z4yqfBCUmBzQDjTNiB0Bpg09jzE3nYmVjmXuGQEUzM=; b=gM18PusLFNpVK4v2TW4EdBAhLOw4Wrk1fUdWBI7AlOMGDp/S0nhHw6FR5iFS5dJLiv vofUvPK++h0B6gaMf4r7h8vLaz3xsGD6yqhXIZ6Tqn7G1xRip9HxvzGehLP2YyX4+UyV Ms7EP4ZQe/83fWHrhxwIw0fXPNCgIu8AL5RVPVCVMd/xbZ6vQK+LM75JRvLoKBhse1GO 5MeTnaJplVNRGwTJRuJqGnvsDO7MhQvU5yC/FMIbleW3lrJe7iA5aLs+fJkAOMxTAHdO Io3PeljLn2zviGgO2KpK9B65VIBTCNazqNISfR6PKNW0SHSEEbcoPt2dxCxx3ifQs1/l jrVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779460033; x=1780064833; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6z4yqfBCUmBzQDjTNiB0Bpg09jzE3nYmVjmXuGQEUzM=; b=IOwI2JRddODQt6XLy0xK3rvcBfrg5weFzSoanZ5bHSe3rSbUKd1I+39I2sK4YGTBC9 vjecj5u1gqEmtu21MUgcG5wmN+DUxiHBoBI0AAZFClmd+G5UjosGpprZ4a1BulTTl7QX cWPpE9COYzM7DmDpEInyWSZRaQZtGk6cpZY9XPpS/weM3+N0u/7fh7mFawyjIpMbytHP C17l9nWFXR7CRzF9tuAaEN4KVlt5p+FNB764ozH0ILqABWrWDVA29Gxr8tAAwNpGY1eE Br5RFeqk7Bw3xCVRtYLlRvnjTHENhplGjgXN6/HFJuoPsi5uC4nxcFQb83wqhMZd387h eZ4A== X-Forwarded-Encrypted: i=1; AFNElJ8nHu987t31X8UFRX5KrupCBfwLoqLibE4WFS2MB48gY/BPSilQyQsnizHFQpReEJw91fzrStpyyWl02+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxPaAITTPdsNCsJKpYv9A9qc3nCHdLGDImWQeTyw4JsRMJLqEz4 oWPphUPynXzy36TTkKsobUa/NHZUU7HnqEca5XdKxo0Qb79Xa1NEnLpLbY50PTmHnP4= X-Gm-Gg: Acq92OGL/1O0FjY8b1UTClwPA5bol7039/FgTXRqgRDF4yecza02MSHfB1kx8lFYO3a hoTelFcHT12Vo8aNQbFQgx3+QHv4Eq4jcC7kYOc3du1MrvvKTqgc6f0J+aMt/GpyWYjUv8TIYU0 NjqWIyTTT7jEIX5BiO6ewv4odWbhqA+RJc3tGc+IatO6dEDgrUnVuaZF9NuPHtdW0lcQrQ0Anq0 gjwllWI4wT8HZ3cEY1pFYhpeaOWgqwepFvi3Dr88Dq9qrywKAHtAAlam9sK0A0lSS7sjrqoMwIa esrdHz9N1Goz1gW8nx/VOfKJpl8OtpqSPWX9UBqd8LZQPSy2O0MCeor/oNavPH2QmHATHv29M2l ztxAnS0+1a4OuzxWoew6WO6IH17D3Is20QI/MLu+iG/4hZ2JPFy9g5h1vnib0+lKlMHu+DryGQm j9RLd6pzMoIw+7O41O49/iubnM/bf1Eyvg4Dag4mzlFxf83USwpzzqJr1/jn577lmJZIHZoAiTY FiXfdpf X-Received: by 2002:a05:6870:ac07:b0:439:bd77:bc43 with SMTP id 586e51a60fabf-43b5af3d4c1mr2273053fac.33.1779460033272; Fri, 22 May 2026 07:27:13 -0700 (PDT) Received: from [192.168.1.102] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43b63a94725sm1734787fac.18.2026.05.22.07.27.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 07:27:12 -0700 (PDT) Message-ID: <55588bd7-aca4-4890-bfb1-c77b6f091674@kernel.dk> Date: Fri, 22 May 2026 08:27:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] block: propagate in_flight to whole disk on partition I/O To: Keith Busch , Tang Yizhou Cc: hch@lst.de, yukuai@fnnas.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Leon Hwang References: <20260522141638.298530-1-yizhou.tang@shopee.com> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/26 8:24 AM, Keith Busch wrote: > On Fri, May 22, 2026 at 10:16:38PM +0800, Tang Yizhou wrote: >> @@ -1073,7 +1073,7 @@ void bdev_end_io_acct(struct block_device *bdev, enum req_op op, >> part_stat_inc(bdev, ios[sgrp]); >> part_stat_add(bdev, sectors[sgrp], sectors); >> part_stat_add(bdev, nsecs[sgrp], jiffies_to_nsecs(duration)); >> - part_stat_local_dec(bdev, in_flight[op_is_write(op)]); >> + bdev_inc_in_flight(bdev, op); > > This one should be bdev_dec_in_flight(). Yes, and let's chill the repostings. Send 1 per day, we've up to v5 in a very short amount of time. Take your time and get it right, and give people a chance to comment and review before randomly throwing version N+1 over the wall. -- Jens Axboe