From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752160AbbETBO0 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 May 2015 21:14:26 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:54062 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751858AbbETBOY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 May 2015 21:14:24 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-d9-555bdfed41ed
Message-id: <555BDFED.7060607@samsung.com>
Date: Wed, 20 May 2015 10:14:21 +0900
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.7.0
MIME-version: 1.0
To: Arnd Bergmann <arnd@arndb.de>, linux-fbdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>, Kukjin Kim <kgene@kernel.org>,
        Inki Dae <inki.dae@samsung.com>, Donghwa Lee <dh09.lee@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] video: exynos: fix modular build
References: <2708563.ADEZz3igC5@wuerfel>
In-reply-to: <2708563.ADEZz3igC5@wuerfel>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsVy+t/xq7pv70eHGry/JW/xd9Ixdovr5+0s
	Jt2fwGLx+oWhRf/j18wWZ5vesFtsenyN1eJE3wdWi8u75rBZzDi/j8li3cMXTBbr599ic+Dx
	+P1rEqPHqwt3WDw2repk89i8pN6jb8sqRo/jN7YzeXzeJBfAHsVlk5Kak1mWWqRvl8CVMe3i
	dKaCb2wVze/cGxjvsXYxcnJICJhIfO1ZyQRhi0lcuLeerYuRi0NIYCmjRHPnDxYI5ymjxNeH
	PSwgVbwCWhK3381nB7FZBFQlbhxoBIuzCRhLbF6+hA3EFhWIkHh7+SQTRL2gxI/J98BqRATs
	JHpXtIFtYBZ4wiQx7/9/sCJhAVOJWT2HwU4SEtCQeP7iI5jNKaApsXHjKqBmDqAGPYn7F7VA
	wswC8hKb17xlnsAoMAvJilkIVbOQVC1gZF7FKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERIj
	X3YwLj5mdYhRgINRiYf3xKHoUCHWxLLiytxDjBIczEoivLNmAoV4UxIrq1KL8uOLSnNSiw8x
	SnOwKInzzt31PkRIID2xJDU7NbUgtQgmy8TBKdXAOKeTq9ywI//hpxsis0MvnWL8M2mhqvBC
	pQL5nXzHFtxbGLXhYFxV79u8/WmugeJpC8Tv7NtxVyyGS/+BY9gZ18dRux4sD59j15f+M3vl
	wcvOQcI+q86dljl2Wp5tv9mhuhkai+MPmUr2pTzOmHVu/qTUsuyQHz5/YvftM1hnmfGrWX73
	s/5lnUosxRmJhlrMRcWJAFg90l+NAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19.05.2015 21:17, Arnd Bergmann wrote:
> The s6e8ax0 driver has a dependency on BACKLIGHT_CLASS_DEVICE,
> which can be configured as a loadable module, so we have to
> make the driver a tristate symbol as well, to avoid this error:
> 
> drivers/built-in.o: In function `s6e8ax0_probe':
> :(.text+0x23a48): undefined reference to `devm_backlight_device_register'
> 
> This also means we get another error from a missing export, which
> this fixes as well:
> 
> ERROR: "exynos_mipi_dsi_register_lcd_driver" [drivers/video/fbdev/exynos/s6e8ax0.ko] undefined!
> 
> Finally, the EXYNOS_VIDEO option is turned into tristate as well
> for good measure, as all framebuffer drivers should be configurable
> as modules.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof