From: Stas Sergeev <stsp@list.ru>
To: linux-leds@vger.kernel.org
Cc: Linux kernel <linux-kernel@vger.kernel.org>,
Stas Sergeev <stsp@users.sourceforge.net>
Subject: [PATCH 0/20] leds: put hard limit on minimum blink period for slow leds
Date: Wed, 20 May 2015 18:17:30 +0300 [thread overview]
Message-ID: <555CA58A.10700@list.ru> (raw)
Currently the timer trigger allows to set blink period as small as
1mS. But in fact the minimum period is jiffy, which is usually 10mS.
The following mail says:
http://lkml.iu.edu/hypermail/linux/kernel/1504.3/03469.html
<<
As I mentioned before even with hr timer it wouldn't be possible
to assure that 1ms is achievable due to locking and bus latency
reasons.
>>
So the limit of 10mS should be enforced for drivers that use
waiting operations, like transfers across slow bus.
This allows to stay on safe side when CONFIG_HZ is set to eg 1000.
This patch set differentiates the "fast" drivers by marking them
with the new LED_BRIGHTNESS_FAST flag. For these drivers, setting
periods as small as 1mS is possible (provided CONFIG_HZ is set
appropriately), while for "slow" drivers the limit of 10mS in enforced.
In the future, the "fast" drivers may get used by a software PWM.
drivers/leds/dell-led.c | 2 +-
drivers/leds/led-core.c | 30 +++++++++++++++++++-----------
drivers/leds/led-triggers.c | 8 +++++---
drivers/leds/leds-asic3.c | 2 +-
drivers/leds/leds-bcm6328.c | 1 +
drivers/leds/leds-clevo-mail.c | 2 +-
drivers/leds/leds-cobalt-qube.c | 1 +
drivers/leds/leds-cobalt-raq.c | 2 ++
drivers/leds/leds-fsg.c | 12 ++++++------
drivers/leds/leds-gpio.c | 2 ++
drivers/leds/leds-hp6xx.c | 4 ++--
drivers/leds/leds-locomo.c | 2 ++
drivers/leds/leds-net48xx.c | 2 +-
drivers/leds/leds-netxbig.c | 2 +-
drivers/leds/leds-ns2.c | 2 +-
drivers/leds/leds-ot200.c | 1 +
drivers/leds/leds-pwm.c | 2 ++
drivers/leds/leds-s3c24xx.c | 2 +-
drivers/leds/leds-ss4200.c | 1 +
drivers/leds/leds-versatile.c | 1 +
drivers/leds/leds-wrap.c | 6 +++---
drivers/leds/trigger/ledtrig-oneshot.c | 5 ++++-
drivers/leds/trigger/ledtrig-timer.c | 18 +++++++++++++-----
include/linux/leds.h | 12 ++++++++++--
24 files changed, 82 insertions(+), 40 deletions(-)
next reply other threads:[~2015-05-20 15:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:17 Stas Sergeev [this message]
2015-05-20 15:19 ` [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag Stas Sergeev
2015-05-21 13:22 ` Jacek Anaszewski
2015-05-21 13:27 ` Stas Sergeev
2015-05-21 13:37 ` Jacek Anaszewski
2015-05-21 15:26 ` Stas Sergeev
2015-05-29 16:24 ` Stas Sergeev
2015-06-01 8:31 ` Jacek Anaszewski
2015-06-01 11:56 ` Stas Sergeev
2015-06-01 14:19 ` Jacek Anaszewski
2015-06-01 14:37 ` Stas Sergeev
2015-06-02 8:11 ` Jacek Anaszewski
2015-05-20 15:20 ` [PATCH 02/20] leds: mark dell-led driver with " Stas Sergeev
2015-05-20 15:21 ` [PATCH 03/20] leds: mark asic3 " Stas Sergeev
2015-05-20 15:22 ` [PATCH 04/20] leds: mark bcm6328 " Stas Sergeev
2015-05-20 15:23 ` [PATCH 05/20] leds: mark clevo-mail " Stas Sergeev
2015-05-20 15:24 ` [PATCH 06/20] leds: mark cobalt-qube " Stas Sergeev
2015-05-20 15:25 ` [PATCH 07/20] leds: mark cobalt-raq " Stas Sergeev
2015-05-20 15:26 ` [PATCH 08/20] leds: mark fsg " Stas Sergeev
2015-05-20 15:27 ` [PATCH 09/20] leds: mark gpio " Stas Sergeev
2015-05-20 15:28 ` [PATCH 10/20] leds: mark hp6xx " Stas Sergeev
2015-05-20 15:29 ` [PATCH 11/20] leds: mark locomo " Stas Sergeev
2015-05-20 15:30 ` [PATCH 12/20] leds: mark net48xx " Stas Sergeev
2015-05-20 15:31 ` [PATCH 13/20] leds: mark netxbig " Stas Sergeev
2015-05-20 15:32 ` [PATCH 14/20] leds: mark ns2 " Stas Sergeev
2015-05-20 15:33 ` [PATCH 15/20] leds: mark ot200 " Stas Sergeev
2015-05-20 15:34 ` [PATCH 16/20] leds: mark pwm " Stas Sergeev
2015-05-20 15:35 ` [PATCH 17/20] leds: mark s3c24xx " Stas Sergeev
2015-05-20 15:35 ` [PATCH 18/20] leds: mark ss4200 " Stas Sergeev
2015-05-20 15:36 ` [PATCH 19/20] leds: mark versatile " Stas Sergeev
2015-05-20 15:37 ` [PATCH 20/20] leds: mark wrap " Stas Sergeev
2015-05-21 15:11 ` [PATCH 02/20] leds: mark dell-led " Stas Sergeev
2015-05-21 15:12 ` [PATCH 03/20] leds: mark asic3 " Stas Sergeev
2015-05-21 15:13 ` [PATCH 04/20] leds: mark bcm6328 " Stas Sergeev
2015-05-21 15:14 ` [PATCH 05/20] leds: mark clevo-mail " Stas Sergeev
2015-05-21 15:15 ` [PATCH 06/20] leds: mark cobalt-qube " Stas Sergeev
2015-05-21 15:15 ` [PATCH 07/20] leds: mark cobalt-raq " Stas Sergeev
2015-05-21 15:16 ` [PATCH 08/20] leds: mark fsg " Stas Sergeev
2015-05-21 15:16 ` [PATCH 09/20] leds: mark gpio " Stas Sergeev
2015-05-21 15:17 ` [PATCH 10/20] leds: mark hp6xx " Stas Sergeev
2015-05-21 15:18 ` [PATCH 11/20] leds: mark locomo " Stas Sergeev
2015-05-21 15:19 ` [PATCH 13/20] leds: mark netxbig " Stas Sergeev
2015-05-21 15:20 ` [PATCH 14/20] leds: mark ns2 " Stas Sergeev
2015-05-21 15:21 ` [PATCH 15/20] leds: mark ot200 " Stas Sergeev
2015-05-26 9:16 ` Christian Gmeiner
2015-05-21 15:21 ` [PATCH 16/20] leds: mark pwm " Stas Sergeev
2015-05-21 15:22 ` [PATCH 17/20] leds: mark s3c24xx " Stas Sergeev
2015-05-21 15:23 ` [PATCH 18/20] leds: mark ss4200 " Stas Sergeev
2015-05-21 15:23 ` [PATCH 19/20] leds: mark versatile " Stas Sergeev
2015-05-22 7:14 ` Linus Walleij
2015-05-22 10:06 ` Stas Sergeev
2015-05-21 15:24 ` [PATCH 20/20] leds: mark wrap " Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555CA58A.10700@list.ru \
--to=stsp@list.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=stsp@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome