From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m82153.xmail.ntesmail.com (mail-m82153.xmail.ntesmail.com [156.224.82.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 904EEA31; Thu, 19 Dec 2024 02:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.224.82.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734573771; cv=none; b=NDoClm/cerct9CqEqYPcEhq5CJTncVxIZdlozrv0GJiTjIbBeSQiH3nfsN8fsZkrKdasR/p2mR2A/W/oFMbiD9TRcdhucJ6ObzENVnK3PipqwDqbLpL4WnRP0vvyOSyoP7cbOnm+YrZEoHB6Dc9m6TouG+IiswW83sxe+R1uAKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734573771; c=relaxed/simple; bh=oro6L8lONRRWsZcKqEKf9qcKp+84mRxTboHKaUfBV6E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X7ujZ8/YSXC8xUFUiV8yOyHQanfkZxgtOQftLgxkjv4JefSnoTJbfTmjpq0XA8ASNPdSg4SRcq3mE+DyrA8GDijzmA8b4O2U0CbCjZK/98gey8VFLlibGvxT3EGiAOkMZeZCUjXRogCdpV/lP+fk/F5BMnzA51Lfj8WyieaX2Cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=bqsYXHXs; arc=none smtp.client-ip=156.224.82.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="bqsYXHXs" Received: from [172.16.12.26] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 627357bb; Thu, 19 Dec 2024 09:27:17 +0800 (GMT+08:00) Message-ID: <5562ec11-c3f5-4068-8ad0-6e93924228ed@rock-chips.com> Date: Thu, 19 Dec 2024 09:27:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/11] arm64: dts: rockchip: Add nodes related to eDP1 for RK3588 To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rfoss@kernel.org, vkoul@kernel.org, sebastian.reichel@collabora.com, cristian.ciocaltea@collabora.com, l.stach@pengutronix.de, andy.yan@rock-chips.com, hjc@rock-chips.com, algea.cao@rock-chips.com, kever.yang@rock-chips.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20241216031225.3746-1-damon.ding@rock-chips.com> <20241216031225.3746-12-damon.ding@rock-chips.com> <2173171.OBFZWjSADL@diego> Content-Language: en-US From: Damon Ding In-Reply-To: <2173171.OBFZWjSADL@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGU0YS1YZTEgeGkoaTEpCTUlWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhCSE NVSktLVUpCS0tZBg++ X-HM-Tid: 0a93dc86bce903a3kunm627357bb X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PSo6Njo4DjIQLhcOC1FILC5R GA0KFA5VSlVKTEhPTkxKTUhCTUxMVTMWGhIXVR8aFhQVVR8SFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJT0pKNwY+ DKIM-Signature:a=rsa-sha256; b=bqsYXHXs55Yr1VKXFAqKwbG3pTDI6pOf1MH+lSZfIXS47nhvI1Ig1J6qFhY7XwkQ92eu8xbX6iLMyX+f5DDUzaXBQd6rTVL18AG8SKr3Vz0udw1E9ygX+EJ4UJUevWRSsgYJxph/dEguPtw/SkA/zmtiVeNxhnWtBYr0liA0y8I=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=UfV7vLRVNdO5jRgpw0XUomLCucGuvPX5lVmqJYm7acg=; h=date:mime-version:subject:message-id:from; Hi Heiko, On 2024/12/18 20:45, Heiko Stübner wrote: > Hi Damon, > > Am Montag, 16. Dezember 2024, 04:12:25 CET schrieb Damon Ding: >> The related nodes are hdptxphy1_grf, hdptxphy1 and edp1. And the >> aliases edp0 and edp1 are added to separate two independent eDP >> devices. >> >> Signed-off-by: Damon Ding >> --- >> .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 55 +++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi >> index 0ce0934ec6b7..17cc0b619744 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi >> @@ -7,6 +7,11 @@ >> #include "rk3588-extra-pinctrl.dtsi" >> >> / { >> + aliases { >> + edp0 = &edp0; >> + edp1 = &edp1; >> + }; >> + > > drop aliases please I will drop it and use the registers to separate edp0 and edp1 in the next version. > > >> @@ -67,6 +72,11 @@ u2phy1_otg: otg-port { >> }; >> }; >> >> + hdptxphy1_grf: syscon@fd5e4000 { >> + compatible = "rockchip,rk3588-hdptxphy-grf", "syscon"; >> + reg = <0x0 0xfd5e4000 0x0 0x100>; >> + }; >> + >> i2s8_8ch: i2s@fddc8000 { >> compatible = "rockchip,rk3588-i2s-tdm"; >> reg = <0x0 0xfddc8000 0x0 0x1000>; > >> @@ -395,6 +434,22 @@ sata-port@0 { >> }; >> }; >> >> + hdptxphy1: phy@fed70000 { >> + compatible = "rockchip,rk3588-hdptx-phy"; >> + reg = <0x0 0xfed70000 0x0 0x2000>; >> + clocks = <&cru CLK_USB2PHY_HDPTXRXPHY_REF>, <&cru PCLK_HDPTX1>; >> + clock-names = "ref", "apb"; >> + #phy-cells = <0>; >> + resets = <&cru SRST_HDPTX1>, <&cru SRST_P_HDPTX1>, >> + <&cru SRST_HDPTX1_INIT>, <&cru SRST_HDPTX1_CMN>, >> + <&cru SRST_HDPTX1_LANE>, <&cru SRST_HDPTX1_ROPLL>, >> + <&cru SRST_HDPTX1_LCPLL>; >> + reset-names = "phy", "apb", "init", "cmn", "lane", "ropll", >> + "lcpll"; >> + rockchip,grf = <&hdptxphy1_grf>; >> + status = "disabled"; >> + }; > > the hdptxphy nodes should be their own patch, also because most likely > Cristian's patch for hdmi1 [0] will be slightly faster. Indeed, it is good to add edp1 node only. > > > [0] https://lore.kernel.org/r/20241211-rk3588-hdmi1-v2-2-02cdca22ff68@collabora.com > > > > > Best regards, Damon