From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753527AbbLIXId (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 18:08:33 -0500
Received: from v094114.home.net.pl ([79.96.170.134]:49693 "HELO
	v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1750810AbbLIXIb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 18:08:31 -0500
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Radivoje Jovanovic <radivoje.jovanovic@intel.com>,
        Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>,
        Mathias Krause <minipli@googlemail.com>,
        Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
Subject: Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check
Date: Thu, 10 Dec 2015 00:38:27 +0100
Message-ID: <5563622.j8xTDST9Ds@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20151209085355.6442a508@icelake>
References: <1449667872-11197-1-git-send-email-prarit@redhat.com> <20151209085355.6442a508@icelake>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, December 09, 2015 08:53:55 AM Jacob Pan wrote:
> On Wed,  9 Dec 2015 08:31:12 -0500
> Prarit Bhargava <prarit@redhat.com> wrote:
> 
> > Intel RAPL initialized on several systems where the BIOS lock bit (msr
> > 0x610, bit 63) was set.  This occured because the return value of
> > rapl_read_data_raw() was being checked, rather than the value of the
> > variable passed in, locked.
> > 
> > This patch properly implments the rapl_read_data_raw() call to check
> > the variable locked, and now the Intel RAPL driver outputs the
> > warning:
> > 
> > 	intel_rapl: RAPL package 0 domain package locked by BIOS
> > 
> > and does not initialize for the package.
> > 
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Radivoje Jovanovic <radivoje.jovanovic@intel.com>
> > Cc: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
> > Cc: Mathias Krause <minipli@googlemail.com>
> > Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> > Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> > 
> > [v2]: fix brackets
> 
> Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

OK, I've put it into my bleeding-edge branch as 4.5 candidate, but do we
want it in "stable" and therefore should it be pushed for 4.4?

Thanks,
Rafael