From: Jens Axboe <axboe@fb.com>
To: NeilBrown <neilb@suse.de>, Keith Busch <keith.busch@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: LOCKDEP warning due to ext_devt_lock
Date: Wed, 27 May 2015 21:32:21 -0600 [thread overview]
Message-ID: <55668C45.3060700@fb.com> (raw)
In-Reply-To: <20150528123233.3df8ff55@notabene.brown>
On 05/27/2015 08:32 PM, NeilBrown wrote:
>
> Hi Keith,
> I'm getting lockdep warning around use of ext_devt_lock.
>
> [11428.266019] inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
>
> As you say in
> 2da78092dda1 ("block: Fix dev_t minor allocation lifetime")
> ext_devt_lock can be taken from call_rcu's soft-irq.
> I think that means it should always use the _irq verion of spinlock.
Wouldn't spin_lock_bh() and friends suffice then?
--
Jens Axboe
next prev parent reply other threads:[~2015-05-28 3:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 2:32 NeilBrown
2015-05-28 3:32 ` Jens Axboe [this message]
2015-05-28 3:45 ` NeilBrown
2015-05-28 16:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55668C45.3060700@fb.com \
--to=axboe@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome