From: Richard Weinberger <richard@nod.at>
To: Chen Gang <gang.chen.5i5j@gmail.com>, jdike@addtoit.com
Cc: user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Thomas Meyer <thomas@m3y3r.de>
Subject: Re: [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue
Date: Sun, 31 May 2015 21:48:41 +0200 [thread overview]
Message-ID: <556B6599.3090801@nod.at> (raw)
In-Reply-To: <542FF203.50907@gmail.com>
Am 04.10.2014 um 15:11 schrieb Chen Gang:
> syscall() is implemented in libc.so/a (e.g. for glibc, in "syscall.o"),
> so for normal ".o" files, it is undefined, neither can be found within
> kernel wide, so will break modpost.
>
> Since ".o" files is OK, can simply export 'syscall' symbol, let modpost
> know about that, then can fix this issue.
>
> The related error (with allmodconfig under um):
>
> MODPOST 1205 modules
> ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined!
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/um/kernel/ksyms.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/um/kernel/ksyms.c b/arch/um/kernel/ksyms.c
> index 543c047..e7780f3 100644
> --- a/arch/um/kernel/ksyms.c
> +++ b/arch/um/kernel/ksyms.c
> @@ -42,3 +42,6 @@ EXPORT_SYMBOL(os_makedev);
> EXPORT_SYMBOL(add_sigio_fd);
> EXPORT_SYMBOL(ignore_sigio_fd);
> EXPORT_SYMBOL(sigio_broken);
> +
> +extern long int syscall (long int __sysno, ...);
> +EXPORT_SYMBOL(syscall);
Thanks Chen, applied to my 4.2 queue!
prev parent reply other threads:[~2015-05-31 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-04 13:11 Chen Gang
2014-10-24 22:52 ` Chen Gang
2015-05-31 19:48 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556B6599.3090801@nod.at \
--to=richard@nod.at \
--cc=gang.chen.5i5j@gmail.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome