From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751069AbdALQdr (ORCPT ); Thu, 12 Jan 2017 11:33:47 -0500 Received: from mout.web.de ([212.227.17.11]:62092 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdALQdp (ORCPT ); Thu, 12 Jan 2017 11:33:45 -0500 Subject: [PATCH 2/5] pinctrl: mvebu: Delete an error message for a failed memory allocation in three functions To: linux-gpio@vger.kernel.org, Laxman Dewangan , Linus Walleij , Sebastian Hesselbarth , Thomas Petazzoni , Wolfram Sang References: <12880bc6-1695-074a-788b-dd936f6f795a@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <556cc243-6bd0-8da1-8c17-c1d6d6206735@users.sourceforge.net> Date: Thu, 12 Jan 2017 17:33:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <12880bc6-1695-074a-788b-dd936f6f795a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YK3Uxt29lzq+MAtMUjUNipR1PvJCvRattZsh46wniKjgfv8YPkT LbH3T3Ea8JFtQJiks7wgROcchJCkw8DUNWNdnnA07EHMDd/1g9YBgg5SGRrp279i4zrg/n9 g6UPWkyBm5zipft3tWfQnhRBXjJZZhHxoJKAuHVvUemeGJVZETrXUhnQ1s0tO45T+JO1AAM M4p9nbx58i2ke7S/8MHmA== X-UI-Out-Filterresults: notjunk:1;V01:K0:xuZmL+uO+/U=:ZjgFMnnIIk1XqRbqAVvV7K bh9bMWP/CdFTW3xibEzkalLL9O1rVTXXtPyg/sw9UgxrQbGC+SfQoRAAhhEtThaZVhEP4S1ug Mx9VME+zHJ2WXezAwo3yC470CpJqUpyD8oVREIGV+Fo8/SnHBUGC7QXpN9/j09zEc2JPOZaQA C5DbmdHq1eBAUC6XjPg06l1dSewDfJZ04dWezivZI3ZCcaQNX5ZAj74weyp4CzL+H5N2qFavm zfxqEB7yYEdN2GnKM+Qrp88mCbF1kKvFGoYlon6qX0dJq7B+v634/wWN7a81vHMceIPeixYod q/puhuAbMg9whN0uwm3VBktSgbzpdijv354oJAKM4VCTRBW8NO0OSkhy+PXXc57iPbJqGIwQf WSL+g+6gAPCALDGNsJqWwX16vZGfenS6NjoKaY/y2hNX944TSJztvrLMHZB/ChhlJ3SImlMMK QtF/Pz7X51OzWk6pypoWXi1DrJa78wR7mGlNY6P6ryBJRpn71BSFppuTJGxZWMKd/xUsFlA+Z kybAtV1f6b72x9bANXRHg/rOoXXRkIOoqOEu+zhpYuO0eimbWH7VZQ18GkCsMMhZAaogo3oVa YIrU6rX9d2RS5Zvyq87XJqVEXhnO6Sjs1o+vZI/EeZ9rmWCCSDUImFRkc1wQpyWPHFF+VTxVL 1kySjzz8BMWZYFNhfh5+6aMhl54sH9SGMTKkTU8xxt8MhyiWff+1KCyj0wl0/otwmXGXK4h/b VnA9OxUDXl0QSXXYTc6qj0d76eOv7KwUCzs26Iq3pMtqQQuyGdKs0u/7PLbYmMQpvaDqoRmda N+T8fHo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 12 Jan 2017 16:15:34 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/pinctrl/mvebu/pinctrl-mvebu.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c index c2f74572ac01..0618311e75dc 100644 --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c @@ -399,12 +399,8 @@ static int mvebu_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev, } *map = kmalloc_array(nmaps, sizeof(**map), GFP_KERNEL); - if (*map == NULL) { - dev_err(pctl->dev, - "cannot allocate pinctrl_map memory for %s\n", - np->name); + if (!*map) return -ENOMEM; - } n = 0; of_property_for_each_string(np, "marvell,pins", prop, group) { @@ -563,10 +559,8 @@ int mvebu_pinctrl_probe(struct platform_device *pdev) pctl = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_pinctrl), GFP_KERNEL); - if (!pctl) { - dev_err(&pdev->dev, "unable to alloc driver\n"); + if (!pctl) return -ENOMEM; - } pctl->desc.name = dev_name(&pdev->dev); pctl->desc.owner = THIS_MODULE; @@ -604,10 +598,8 @@ int mvebu_pinctrl_probe(struct platform_device *pdev) pdesc = devm_kzalloc(&pdev->dev, pctl->desc.npins * sizeof(struct pinctrl_pin_desc), GFP_KERNEL); - if (!pdesc) { - dev_err(&pdev->dev, "failed to alloc pinctrl pins\n"); + if (!pdesc) return -ENOMEM; - } for (n = 0; n < pctl->desc.npins; n++) pdesc[n].number = n; -- 2.11.0