From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22037C433E0 for ; Mon, 22 Mar 2021 15:56:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCA2C61990 for ; Mon, 22 Mar 2021 15:56:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbhCVPz7 (ORCPT ); Mon, 22 Mar 2021 11:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230483AbhCVPzf (ORCPT ); Mon, 22 Mar 2021 11:55:35 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A904C061574 for ; Mon, 22 Mar 2021 08:55:34 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo9260918wmq.4 for ; Mon, 22 Mar 2021 08:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=N70P1Fv2IBxK4ZquldWYilx1VEi3AUb2VlVmZR63sTo=; b=zLNjUSngfbuLk40AkFOm0Q21v63/nm8pheW4TD9Z4ThOhAtKi1I10n56YpWu3koPfJ 3f4sCT1VO4SK8UYsjLD6avAulBxAWe0EVQbVqb3h1+O3NHsMLA3D4MTvCgO0iCURsjwl t12czLy5mgKaMfaCA+bLTryBti8a1m0m/ucoWgQYIw7M0JotHZulalCabJFB23rbhS+Z K2LvhSvjYcDYMENaczrp6zVBkksqJtJvLyTxFLwYVVna0jCZ2Qak5600Iz4Xy2pMBj/L 1LegYlQonll16R6hzGNPa/7QI6eKMFOgSuogxvq64n1PRBZTWVVAQ7qyLujYGREvum2B dySg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N70P1Fv2IBxK4ZquldWYilx1VEi3AUb2VlVmZR63sTo=; b=fXiZB5iWQHlJV2WJc/GCuzXzFm3nISEqWQpvGWukLlJ0xgRPbwaQGFU3wosI7tHWlS dkqGEOOZ0b/eNmXEvHxRbaFhVyjhkaIqcgetJjtXMzm9wApFy/12yjtXsXNLLRjFizSb 79DcZhtgOZtLlvOUauxLrxe5R1b9+H74iyC08HooecRUFubgWKcKojjkYPe6w9hat5LG o7BNdwE/ziLKLUPFMnEJbOFLPgmpD6PcM5+LcvK0AG4R2gbGrNyMrFPk2nta/lqGlcfC apuJJqMv1KBRd+sW7TMjjvnLwjuJocude2I8NpcOv6deAtnGQpkQbmVxTgpI04VqsA8j ICbQ== X-Gm-Message-State: AOAM533zg+1Kj06itPaWP070JAb+blR1mZkIBZmNt0zkfKXLcQkk4iX8 5OKeVkQB70bHEtH91ldyfCR3ow== X-Google-Smtp-Source: ABdhPJwhrBA1PH1wFRcOMG8NB/r5aJoIfErXREF/rZUXctaKeXrTXYz71Ltn3UvLIg5V1x6wZ0rJUw== X-Received: by 2002:a1c:bd55:: with SMTP id n82mr459851wmf.3.1616428532777; Mon, 22 Mar 2021 08:55:32 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:2091:71d6:3ab2:37f2? ([2a01:e34:ed2f:f020:2091:71d6:3ab2:37f2]) by smtp.googlemail.com with ESMTPSA id l9sm15936903wmq.2.2021.03.22.08.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 08:55:32 -0700 (PDT) Subject: Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue To: Tony Lindgren , Thomas Gleixner Cc: Keerthy , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tero Kristo References: <20210304073737.15810-1-tony@atomide.com> <20210304073737.15810-2-tony@atomide.com> From: Daniel Lezcano Message-ID: <556d55af-0b30-8751-6aef-2e1bb9db1a76@linaro.org> Date: Mon, 22 Mar 2021 16:55:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210304073737.15810-2-tony@atomide.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2021 08:37, Tony Lindgren wrote: > There is a timer wrap issue on dra7 for the ARM architected timer. > In a typical clock configuration the timer fails to wrap after 388 days. > > To work around the issue, we need to use timer-ti-dm timers instead. > > Let's prepare for adding support for percpu timers by adding a common > dmtimer_clkevt_init_common() and call it from dmtimer_clockevent_init(). > This patch makes no intentional functional changes. > > Signed-off-by: Tony Lindgren > --- [ ... ] > @@ -575,33 +574,60 @@ static int __init dmtimer_clockevent_init(struct device_node *np) > */ > writel_relaxed(OMAP_TIMER_CTRL_POSTED, t->base + t->ifctrl); > > + if (dev->cpumask == cpu_possible_mask) > + irqflags = IRQF_TIMER; > + else > + irqflags = IRQF_TIMER | IRQF_NOBALANCING; Can you explain the reasoning behind the test above ? [ ... ] -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog