From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B00CC433E7 for ; Fri, 16 Oct 2020 09:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EC5F20848 for ; Fri, 16 Oct 2020 09:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406393AbgJPJtG (ORCPT ); Fri, 16 Oct 2020 05:49:06 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39779 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405433AbgJPJtG (ORCPT ); Fri, 16 Oct 2020 05:49:06 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kTMMB-00054p-U9; Fri, 16 Oct 2020 09:49:03 +0000 Subject: Re: [PATCH] vfio/fsl-mc: fix the return of the uninitialized variable ret To: Diana Craciun OSS , Alex Williamson Cc: Cornelia Huck , Eric Auger , kvm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201015122226.485911-1-colin.king@canonical.com> <20201015125211.3ff46dc1@w520.home> <65c7ffdb-fa92-102d-d7d1-29bb7d39fcb7@oss.nxp.com> From: Colin Ian King Message-ID: <556df27a-d4aa-ccbf-7559-52b7c0e05c0f@canonical.com> Date: Fri, 16 Oct 2020 10:49:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <65c7ffdb-fa92-102d-d7d1-29bb7d39fcb7@oss.nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/10/2020 10:26, Diana Craciun OSS wrote: > On 10/15/2020 9:52 PM, Alex Williamson wrote: >> On Thu, 15 Oct 2020 13:22:26 +0100 >> Colin King wrote: >> >>> From: Colin Ian King >>> >>> Currently the success path in function vfio_fsl_mc_reflck_attach is >>> returning an uninitialized value in variable ret. Fix this by setting >>> this to zero to indicate success. >>> >>> Addresses-Coverity: ("Uninitialized scalar variable") >>> Fixes: f2ba7e8c947b ("vfio/fsl-mc: Added lock support in preparation >>> for interrupt handling") >>> Signed-off-by: Colin Ian King >>> --- >>>   drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c >>> b/drivers/vfio/fsl-mc/vfio_fsl_mc.c >>> index 80fc7f4ed343..42a5decb78d1 100644 >>> --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c >>> +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c >>> @@ -84,6 +84,7 @@ static int vfio_fsl_mc_reflck_attach(struct >>> vfio_fsl_mc_device *vdev) >>>           vfio_fsl_mc_reflck_get(cont_vdev->reflck); >>>           vdev->reflck = cont_vdev->reflck; >>>           vfio_device_put(device); >>> +        ret = 0; >>>       } >>>     unlock: >> >> Looks correct to me, unless Diana would rather set the initial value to >> zero instead.  Thanks, >> >> Alex >> > > > I prefer to initialize the variable to 0 when it's defined. I'll send a > patch for it. Yep, works for me. > > Thanks, > Diana