From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
srinivas.kandagatla@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, amitk@kernel.org,
thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
lukasz.luba@arm.com, andersson@kernel.org,
konradybcio@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Cc: quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH v9 4/7] arm64: dts: qcom: ipq5332: Add tsens node
Date: Fri, 13 Dec 2024 13:59:40 +0100 [thread overview]
Message-ID: <556ff23c-8b2c-4ea3-99dc-84196e3f0651@oss.qualcomm.com> (raw)
In-Reply-To: <20241125050728.3699241-5-quic_mmanikan@quicinc.com>
On 25.11.2024 6:07 AM, Manikanta Mylavarapu wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>
> IPQ5332 has tsens v2.3.3 peripheral. This patch adds the tsens
> node with nvmem cells for calibration data.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---
[...]
>
> + tsens: thermal-sensor@4a9000 {
> + compatible = "qcom,ipq5332-tsens";
> + reg = <0x004a9000 0x1000>,
> + <0x004a8000 0x1000>;
> + nvmem-cells = <&tsens_mode>,
> + <&tsens_base0>,
> + <&tsens_base1>,
> + <&tsens_sens11_off>,
> + <&tsens_sens12_off>,
> + <&tsens_sens13_off>,
> + <&tsens_sens14_off>,
> + <&tsens_sens15_off>;
> + nvmem-cell-names = "mode",
> + "base0",
> + "base1",
> + "tsens_sens11_off",
> + "tsens_sens12_off",
> + "tsens_sens13_off",
> + "tsens_sens14_off",
> + "tsens_sens15_off";
> + interrupts = <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "combined";
Please move interrupts properties above nvmem
with that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2024-12-13 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 5:07 [PATCH v9 0/7] Add TSENS support for IPQ5332, IPQ5424 Manikanta Mylavarapu
2024-11-25 5:07 ` [PATCH v9 1/7] dt-bindings: thermal: tsens: Add ipq5332, ipq5424 compatible Manikanta Mylavarapu
2024-11-25 5:07 ` [PATCH v9 2/7] dt-bindings: nvmem: Add compatible for IPQ5424 Manikanta Mylavarapu
2024-11-25 5:07 ` [PATCH v9 3/7] thermal/drivers/tsens: Add TSENS enable and calibration support for V2 Manikanta Mylavarapu
2024-11-26 12:06 ` Dmitry Baryshkov
2024-12-13 19:02 ` Christophe JAILLET
2024-12-18 11:22 ` Manikanta Mylavarapu
2024-11-25 5:07 ` [PATCH v9 4/7] arm64: dts: qcom: ipq5332: Add tsens node Manikanta Mylavarapu
2024-12-13 12:59 ` Konrad Dybcio [this message]
2024-12-18 11:15 ` Manikanta Mylavarapu
2024-11-25 5:07 ` [PATCH v9 5/7] arm64: dts: qcom: ipq5332: Add thermal zone nodes Manikanta Mylavarapu
2024-11-25 5:07 ` [PATCH v9 6/7] arm64: dts: qcom: ipq5424: Add tsens node Manikanta Mylavarapu
2024-12-13 13:00 ` Konrad Dybcio
2024-12-18 11:17 ` Manikanta Mylavarapu
2024-11-25 5:07 ` [PATCH v9 7/7] arm64: dts: qcom: ipq5424: Add thermal zone nodes Manikanta Mylavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556ff23c-8b2c-4ea3-99dc-84196e3f0651@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®