From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73525C47087 for ; Wed, 26 May 2021 02:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47CE361430 for ; Wed, 26 May 2021 02:42:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232270AbhEZCoK (ORCPT ); Tue, 25 May 2021 22:44:10 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3971 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232103AbhEZCoJ (ORCPT ); Tue, 25 May 2021 22:44:09 -0400 Received: from dggems706-chm.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FqZrz5zCFzQshl; Wed, 26 May 2021 10:38:59 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 26 May 2021 10:42:33 +0800 Received: from [127.0.0.1] (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 26 May 2021 10:42:32 +0800 Subject: Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message To: Randy Dunlap , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , "Daniel Bristot de Oliveira" , linux-kernel References: <20210526021856.9060-1-thunder.leizhen@huawei.com> <42d36255-c1a6-956a-b56b-0c09eee125ec@infradead.org> From: "Leizhen (ThunderTown)" Message-ID: <5571d34f-1965-8d8e-3033-6352dd0dcaee@huawei.com> Date: Wed, 26 May 2021 10:42:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <42d36255-c1a6-956a-b56b-0c09eee125ec@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/26 10:32, Randy Dunlap wrote: > On 5/25/21 7:18 PM, Zhen Lei wrote: >> The misspelled word 'borken' should be 'broken'. >> >> Fixes: 6ae72dff3759 ("sched: Robustify topology setup") >> Signed-off-by: Zhen Lei >> --- >> kernel/sched/topology.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c >> index 55a0a243e871..80295e224442 100644 >> --- a/kernel/sched/topology.c >> +++ b/kernel/sched/topology.c >> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve >> >> if (!cpumask_subset(sched_domain_span(child), >> sched_domain_span(sd))) { >> - pr_err("BUG: arch topology borken\n"); >> + pr_err("BUG: arch topology broken\n"); > > Would "borked" or "b0rken" be clearer? These two words don't seem to exist at all. Linux is an open-source code for the world, so it's better to use a more common word. > >> #ifdef CONFIG_SCHED_DEBUG >> pr_err(" the %s domain not a subset of the %s domain\n", >> child->name, sd->name); >> > > > I.e., this is misspelt on purpose. > > Reply to a previous version of this patch: > https://lore.kernel.org/lkml/1493036801.6266.12.camel@gmx.de/ > > cheers. >