mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: media: qcom,venus-common: Add IOMMU IOVA reservation region
Date: Wed, 22 Jul 2026 23:03:05 +0100	[thread overview]
Message-ID: <557377b0-7a21-45b6-b62c-d3b34a6a29f4@linaro.org> (raw)
In-Reply-To: <20260722-shikra_vpu-v5-1-3d80babd4672@oss.qualcomm.com>

On 22/07/2026 14:41, Vikash Garodia wrote:
> Update the memory-region property to support two regions:
> 1. Firmware-loaded codec carveout (existing)
> 2. IOMMU IOVA reservation region (new)
> 
> The IOMMU IOVA reservation region is required to restrict usage of
> specific IOVA memory range. For example, VPU restricts usage of 600MB
> for specific streams, which could otherwise lead to device crash. This
> change allows platforms to define separate memory regions for codec
> carveout and IOVA restrictions.
> This schema update supports existing DTS having single memory-region,
> thereby allowing gradual migration of DTS to support two memory region.
> 
> Signed-off-by: Vikash Garodia<vikash.garodia@oss.qualcomm.com>
> ---

I'm not mega-happy with this pattern being used - I prefer the pixel 
pixel_cb sub-node model you've proposed yourself.

OTOH you're the maintainer so its really up to you how you want to 
arbitrate this - the 600MB constraint will work even if its not pretty 
or the best thing (tm).

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

  reply	other threads:[~2026-07-22 22:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 13:41 [PATCH v5 0/4] media: qcom: Add support for the iris codec on shikra Vikash Garodia
2026-07-22 13:41 ` [PATCH v5 1/4] dt-bindings: media: qcom,venus-common: Add IOMMU IOVA reservation region Vikash Garodia
2026-07-22 22:03   ` Bryan O'Donoghue [this message]
2026-07-23  9:06     ` Konrad Dybcio
2026-07-23 10:44       ` Vikash Garodia
2026-07-29 12:21         ` Konrad Dybcio
2026-07-29 12:21           ` Konrad Dybcio
2026-07-30  8:50           ` Vikash Garodia
2026-07-24  5:59   ` Krzysztof Kozlowski
2026-07-22 13:41 ` [PATCH v5 2/4] dt-bindings: media: qcom,qcm2290-venus: document shikra venus compatible Vikash Garodia
2026-07-24  6:03   ` Krzysztof Kozlowski
2026-07-22 13:41 ` [PATCH v5 3/4] arm64: dts: qcom: shikra: Add Iris video codec node Vikash Garodia
2026-07-22 13:41 ` [PATCH v5 4/4] arm64: dts: qcom: shikra-evk: Enable Iris core Vikash Garodia
2026-09-17 10:39 ` [PATCH v5 0/4] media: qcom: Add support for the iris codec on shikra Vikash Garodia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557377b0-7a21-45b6-b62c-d3b34a6a29f4@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=jorge.ramirez@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®