From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Maso Huang <maso.huang@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Trevor Wu <trevor.wu@mediatek.com>, Arnd Bergmann <arnd@arndb.de>,
Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>,
Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 6/6] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document
Date: Fri, 28 Jul 2023 14:26:47 +0100 [thread overview]
Message-ID: <557424df-a8bf-4b52-af4e-7f6dbe660cea@sirena.org.uk> (raw)
In-Reply-To: <a4f071a0-9e41-4de1-6721-f8d47475f41e@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Fri, Jul 28, 2023 at 02:51:26PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 11:08, Maso Huang wrote:
> > + - assigned-clocks
> > + - assigned-clock-parents
> You should constrain your clocks per variants. I doubt that they are
> really so flexible/optional on each SoC... or maybe missing clocks are
> result of unimplemented parts in the driver? But then this should not
> really affect bindings. Bindings still should require such clocks. Your
> DTS can always provide a <0>, if needed.
Depending on what the clocks are some of them might genuinely be
optional, it's fairly common for audio devices to have multiple clock
inputs and be able to select between them depending on system
requirements or to have bidirectional clock pins which may be either a
provider or consumer depending on system configuration. No idea how
that applies with this specific device.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-07-28 13:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 9:08 [PATCH v3 0/6] ASoC: mediatek: Add support for MT7986 SoC Maso Huang
2023-07-28 9:08 ` [PATCH v3 1/6] ASoC: mediatek: mt7986: add common header Maso Huang
2023-08-04 9:15 ` Alexandre Mergnat
2023-08-04 10:24 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 2/6] ASoC: mediatek: mt7986: support etdm in platform driver Maso Huang
2023-08-04 9:57 ` Alexandre Mergnat
2023-08-08 7:49 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 3/6] ASoC: mediatek: mt7986: add " Maso Huang
2023-07-28 9:38 ` AngeloGioacchino Del Regno
2023-07-28 10:13 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 4/6] ASoC: mediatek: mt7986: add machine driver with wm8960 Maso Huang
2023-07-28 9:49 ` AngeloGioacchino Del Regno
2023-07-28 9:52 ` AngeloGioacchino Del Regno
2023-07-31 6:50 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 5/6] ASoC: dt-bindings: mediatek,mt7986-wm8960: add mt7986-wm8960 document Maso Huang
2023-07-28 9:55 ` AngeloGioacchino Del Regno
2023-07-28 10:16 ` Maso Huang (黃加竹)
2023-07-31 6:42 ` Maso Huang (黃加竹)
2023-07-31 10:44 ` AngeloGioacchino Del Regno
2023-07-31 12:38 ` Maso Huang (黃加竹)
2023-07-28 12:49 ` Krzysztof Kozlowski
2023-07-31 7:31 ` Maso Huang (黃加竹)
2023-07-31 8:14 ` Krzysztof Kozlowski
2023-07-31 14:56 ` Krzysztof Kozlowski
2023-08-04 7:08 ` Maso Huang (黃加竹)
2023-07-28 9:08 ` [PATCH v3 6/6] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document Maso Huang
2023-07-28 10:00 ` AngeloGioacchino Del Regno
2023-07-28 10:19 ` Maso Huang (黃加竹)
2023-07-28 12:51 ` Krzysztof Kozlowski
2023-07-28 13:26 ` Mark Brown [this message]
2023-08-01 8:25 ` Maso Huang (黃加竹)
2023-08-04 9:45 ` Krzysztof Kozlowski
2023-08-04 10:29 ` Maso Huang (黃加竹)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557424df-a8bf-4b52-af4e-7f6dbe660cea@sirena.org.uk \
--to=broonie@kernel.org \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=chenxiangrui@huaqin.corp-partner.google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maso.huang@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®