Re: [PATCH 0/7] irqchip: Use devm_platform_ioremap_resource()

[Marc Zyngier <marc.zyngier@arm.com>]

On 04/04/2019 08:20, Mukesh Ojha wrote:
> Hi All,
> 
> This is just a minor change to promote using of this api
> devm_platform_ioremap_resource() and nothing else functional
> change it does.
> 
> Also, there are patches where only ioremap is used without requesting
> the mem region so this devm_platform_ioremap_resource() take cares all
> of that in single call.

This series has a number of problems:

- It seems to introduce bugs rather than fixing anything
- It doesn't do a complete job of cleaning up the drivers
- Patch 4 does more than it is advertises doing
- You haven't cc'd the authors of these drivers, which would be common
courtesy

For a series that is a "minor change", that's a bit much. Please do not
send such blanket changes without understanding what you are doing.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...