From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932108AbbFIBnJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Jun 2015 21:43:09 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:9177 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750814AbbFIBnD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Jun 2015 21:43:03 -0400
Message-ID: <557643EB.8000106@huawei.com>
Date: Tue, 9 Jun 2015 09:39:55 +0800
From: Bintian <bintian.wang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: Shawn Guo <shawnguo@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <catalin.marinas@arm.com>, <will.deacon@arm.com>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
        <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <khilman@linaro.org>, <mturquette@linaro.org>,
        <rob.herring@linaro.org>, <zhangfei.gao@linaro.org>,
        <haojian.zhuang@linaro.org>, <xuwei5@hisilicon.com>,
        <jh80.chung@samsung.com>, <olof@lixom.net>, <yanhaifeng@gmail.com>,
        <sboyd@codeaurora.org>, <xuejiancheng@huawei.com>,
        <sledge.yanwei@huawei.com>, <tomeu.vizoso@collabora.com>,
        <linux@arm.linux.org.uk>, <guodong.xu@linaro.org>,
        <jorge.ramirez-ortiz@linaro.org>, <tyler.baker@linaro.org>,
        <khilman@kernel.org>, <pebolle@tiscali.nl>, <arnd@arndb.de>,
        <marc.zyngier@arm.com>, <dan.zhao@hisilicon.com>,
        <huxinwei@huawei.com>, <xuyiping@hisilicon.com>,
        <wangbintian@gmail.com>, <victor.lixin@hisilicon.com>,
        <puck.chen@hisilicon.com>, <wangbinghui@hisilicon.com>,
        <zhenwei.wang@hisilicon.com>, <liguozhu@hisilicon.com>,
        <kong.kongxinwei@hisilicon.com>, <heyunlei@huawei.com>,
        <w.f@huawei.com>, <z.liuxinliang@huawei.com>
Subject: Re: [PATCH v9 5/6] arm64: dts: Add dts files for Hisilicon Hi6220
 SoC
References: <1432950661-23060-1-git-send-email-bintian.wang@huawei.com> <1432950661-23060-6-git-send-email-bintian.wang@huawei.com> <20150609005521.GA21682@tiger>
In-Reply-To: <20150609005521.GA21682@tiger>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.68.103]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Shawn,

On 2015/6/9 8:55, Shawn Guo wrote:
> A minor random comment below.
>
> On Sat, May 30, 2015 at 09:51:00AM +0800, Bintian Wang wrote:
>> +		ao_ctrl: ao_ctrl {
>> +			compatible = "hisilicon,hi6220-aoctrl", "syscon";
>> +			reg = <0x0 0xf7800000 0x0 0x2000>;
>> +			#clock-cells = <1>;
>> +		};
>> +
>> +		sys_ctrl: sys_ctrl {
>> +			compatible = "hisilicon,hi6220-sysctrl", "syscon";
>> +			reg = <0x0 0xf7030000 0x0 0x2000>;
>> +			#clock-cells = <1>;
>> +		};
>> +
>> +		media_ctrl: media_ctrl {
>> +			compatible = "hisilicon,hi6220-mediactrl", "syscon";
>> +			reg = <0x0 0xf4410000 0x0 0x1000>;
>> +			#clock-cells = <1>;
>> +		};
>> +
>> +		pm_ctrl: pm_ctrl {
>
> An unit-address should be coded in the node name, when it has a 'reg'
> property.
Thanks for your suggestion, Rob also gives me the same suggestion :)

In fact, I added the reg to node name in the "[GIT PULL]Hisilicon 64-bit
soc hi6220 DT changes for 4.2", but it seems the pull is too late for
kernel 4.2, I will prepare it for 4.3.

Thanks,

Bintian

>
> Shawn
>
>> +			compatible = "hisilicon,hi6220-pmctrl", "syscon";
>> +			reg = <0x0 0xf7032000 0x0 0x1000>;
>> +			#clock-cells = <1>;
>> +		};
>
> .
>