From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753179AbbFICdO (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Jun 2015 22:33:14 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:53907 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751956AbbFICdG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Jun 2015 22:33:06 -0400
Message-ID: <55764FD7.2000805@huawei.com>
Date: Tue, 9 Jun 2015 10:30:47 +0800
From: Bintian <bintian.wang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: Shawn Guo <shawnguo@kernel.org>, <xuwei5@hisilicon.com>, <olof@lixom.net>,
        <khilman@kernel.org>, <arnd@arndb.de>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <catalin.marinas@arm.com>, <will.deacon@arm.com>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
        <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <khilman@linaro.org>, <mturquette@linaro.org>,
        <rob.herring@linaro.org>, <zhangfei.gao@linaro.org>,
        <haojian.zhuang@linaro.org>, <jh80.chung@samsung.com>,
        <yanhaifeng@gmail.com>, <sboyd@codeaurora.org>,
        <xuejiancheng@huawei.com>, <sledge.yanwei@huawei.com>,
        <tomeu.vizoso@collabora.com>, <linux@arm.linux.org.uk>,
        <guodong.xu@linaro.org>, <jorge.ramirez-ortiz@linaro.org>,
        <tyler.baker@linaro.org>, <pebolle@tiscali.nl>, <marc.zyngier@arm.com>,
        <dan.zhao@hisilicon.com>, <huxinwei@huawei.com>,
        <xuyiping@hisilicon.com>, <wangbintian@gmail.com>,
        <victor.lixin@hisilicon.com>, <puck.chen@hisilicon.com>,
        <wangbinghui@hisilicon.com>, <zhenwei.wang@hisilicon.com>,
        <liguozhu@hisilicon.com>, <kong.kongxinwei@hisilicon.com>,
        <heyunlei@huawei.com>, <w.f@huawei.com>, <z.liuxinliang@huawei.com>,
        Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH v9 5/6] arm64: dts: Add dts files for Hisilicon Hi6220
 SoC
References: <1432950661-23060-1-git-send-email-bintian.wang@huawei.com> <1432950661-23060-6-git-send-email-bintian.wang@huawei.com> <20150609005521.GA21682@tiger> <557643EB.8000106@huawei.com>
In-Reply-To: <557643EB.8000106@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.68.103]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020203.55764FEE.000C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 1552ab52e78b17371b9040b7a0918030
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Arnd, Hello Olof, Hello Kevin,

I checked the git log of Linux 4.1-rc7 from Linus, he says Linux 4.1
will have an rc8, so we may have time to review the following two pull
requests from Wei Xu?

[GIT PULL v2]Hisilicon 64-bit SoC changes for 4.2
[GIT PULL]Hisilicon 64-bit soc hi6220 DT changes for 4.2

Thanks for your time.

BR,

Bintian


On 2015/6/9 9:39, Bintian wrote:
> Hello Shawn,
>
> On 2015/6/9 8:55, Shawn Guo wrote:
>> A minor random comment below.
>>
>> On Sat, May 30, 2015 at 09:51:00AM +0800, Bintian Wang wrote:
>>> +        ao_ctrl: ao_ctrl {
>>> +            compatible = "hisilicon,hi6220-aoctrl", "syscon";
>>> +            reg = <0x0 0xf7800000 0x0 0x2000>;
>>> +            #clock-cells = <1>;
>>> +        };
>>> +
>>> +        sys_ctrl: sys_ctrl {
>>> +            compatible = "hisilicon,hi6220-sysctrl", "syscon";
>>> +            reg = <0x0 0xf7030000 0x0 0x2000>;
>>> +            #clock-cells = <1>;
>>> +        };
>>> +
>>> +        media_ctrl: media_ctrl {
>>> +            compatible = "hisilicon,hi6220-mediactrl", "syscon";
>>> +            reg = <0x0 0xf4410000 0x0 0x1000>;
>>> +            #clock-cells = <1>;
>>> +        };
>>> +
>>> +        pm_ctrl: pm_ctrl {
>>
>> An unit-address should be coded in the node name, when it has a 'reg'
>> property.
> Thanks for your suggestion, Rob also gives me the same suggestion :)
>
> In fact, I added the reg to node name in the "[GIT PULL]Hisilicon 64-bit
> soc hi6220 DT changes for 4.2", but it seems the pull is too late for
> kernel 4.2, I will prepare it for 4.3.
>
> Thanks,
>
> Bintian
>
>>
>> Shawn
>>
>>> +            compatible = "hisilicon,hi6220-pmctrl", "syscon";
>>> +            reg = <0x0 0xf7032000 0x0 0x1000>;
>>> +            #clock-cells = <1>;
>>> +        };
>>
>> .
>>
>
>
> .
>