From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbdJCIkp (ORCPT ); Tue, 3 Oct 2017 04:40:45 -0400 Received: from mout.web.de ([212.227.15.4]:50514 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbdJCIko (ORCPT ); Tue, 3 Oct 2017 04:40:44 -0400 To: linux-arm-kernel@lists.infradead.org, Liviu Dudau , Lorenzo Pieralisi , Russell King , Sudeep Holla Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions Message-ID: <557666e2-45b6-8f47-2fc9-756bd7f23541@users.sourceforge.net> Date: Tue, 3 Oct 2017 10:40:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:I35kZCcR+P0L4nTXoRIuKadDGNg0pEgQFvmUZpZB3AldASqoFlQ OCGGDBmasi0rbUm0DWMMXHsfEq9W02e7Y+Ga9YxdY9VzuIsnW69cBMxX0+m6CE91F+8dDi8 /Ok6BPrzkUwmbi5htrF5HYd3KjZF/Db7eeSsBZC3yqya4K2ceep+MbibW2WLqOGPzZrwv2i mOfG1Gv4pSmxh3jSGWK7A== X-UI-Out-Filterresults: notjunk:1;V01:K0:kazxM5Nr8Tg=:C7grZdpMn/Ua52iMJ4NDXZ dWVeetY6YbXTuupE+nrabRTycX6CvK8Jr0KWQ2CgrFMaqgmCJvaM/dGuP1oWoeOuAJoL+dh3H PhYNCjYzpb599cVMWYGRgG0KfnsPV0T1y+xd/MEo88R7srQOKJhINg+iBEZgenHSSnZwirq66 k8Tzqrib71dGwyeg+yt9wkibNJaUOz5i1G05k8NsMrs4fXKouNc5fdh0/tpukFKzBHf4w5jpx kPscaTPkcrS18xUdEO+eQFHchBTn7gtrtHsEf2/Eo2NbhKfCK9GoYUCql/nurjpuSPOnuR3j0 930d/LaSbyEIwuu3EB0I+YGhwFFT2hXPYkFwA20sq9LW+mNSMePHnTC0OFVU2m4bvh17ewwPs M+TUxsSzXsfQy+i9OGSekBzDRmiZfMQQCkDAjC8Oq2VhKZZd2QLTgoej/ogPuFkP6UHDqhg9Q maww+WnBdQfuB2QcPelrjRcgFQ4llBAsAzqemhIFiH8anhje1NtcKFhDaLHhgU2HZe8OFCHfS hbaXCMkyvcTHz7oyu8yCwTQany91Vc2/UtRMZJ42iTSroIdmwiMw6ghP2EQ6vI/ewDP9w/2Bm iWin7e5iwPGlmGrLA+nxSR2we95OkkVTLNIPNEsrJJsC8k+9A/9wOtDTYi5S+GxYkk8Fe6gcg uyHISfVFGzUofd9t+xxV8duLAdekQvtNzpHGM/jFD6+zLGOi2TQcea1kFppTSsVPX0ffHjl63 BAKikhCulnjBN8D9urz2gixJUNoYmqEG2Bmyd4Rdt5wifQHPrvnT/tfcDJU/Ez1c8oYn8hVb3 NYw7gT7r7U5X+YkOl+Plb3IXBUSn6zSxGMS5ghPKoOu2cy4owA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 3 Oct 2017 10:30:07 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/mach-vexpress/spc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-vexpress/spc.c b/arch/arm/mach-vexpress/spc.c index fe488523694c..21c064267af5 100644 --- a/arch/arm/mach-vexpress/spc.c +++ b/arch/arm/mach-vexpress/spc.c @@ -451,10 +451,8 @@ int __init ve_spc_init(void __iomem *baseaddr, u32 a15_clusid, int irq) { int ret; info = kzalloc(sizeof(*info), GFP_KERNEL); - if (!info) { - pr_err(SPCLOG "unable to allocate mem\n"); + if (!info) return -ENOMEM; - } info->baseaddr = baseaddr; info->a15_clusid = a15_clusid; @@ -535,10 +533,8 @@ static struct clk *ve_spc_clk_register(struct device *cpu_dev) struct clk_spc *spc; spc = kzalloc(sizeof(*spc), GFP_KERNEL); - if (!spc) { - pr_err("could not allocate spc clk\n"); + if (!spc) return ERR_PTR(-ENOMEM); - } spc->hw.init = &init; spc->cluster = topology_physical_package_id(cpu_dev->id); -- 2.14.2