From: Daniel Wagner <wagi@monom.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: daniel.wagner@bmw-carit.de, masami.hiramatsu.pt@hitachi.com,
namhyung@kernel.org, josh@joshtriplett.org, andi@firstfloor.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling a trigger
Date: Sat, 13 Jun 2015 08:45:00 +0000 [thread overview]
Message-ID: <557BED8C.6050406@monom.org> (raw)
In-Reply-To: <20150612140107.4ced7f75@gandalf.local.home>
On 06/12/2015 06:01 PM, Steven Rostedt wrote:
>
> Why v3 in the subject?
This patch has not changed since v3 I guess.
>
> On Mon, 8 Jun 2015 16:32:00 -0500
> Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
>
>> When a trigger is enabled, the cond flag should be set beforehand,
>> otherwise a trigger that's expecting to process a trace record
>> (e.g. one with post_trigger set) could be invoked without one.
>>
>> Likewise a trigger's cond flag should be reset after it's disabled,
>> not before.
>>
>> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> Why is Daniel signed off by here?
I have reported the issue and send a fix for this patch
https://lkml.org/lkml/2015/4/21/161
I would have complained if I wasn't okay with it.
cheers,
daniel
next prev parent reply other threads:[~2015-06-13 8:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 21:31 [PATCH v7 00/10] tracing: 'hist' triggers Tom Zanussi
2015-06-08 21:32 ` [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling a trigger Tom Zanussi
2015-06-12 18:01 ` Steven Rostedt
2015-06-13 8:45 ` Daniel Wagner [this message]
2015-06-15 7:02 ` Daniel Wagner
2015-06-29 20:25 ` Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 02/10] tracing: Make ftrace_event_field checking functions available Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 03/10] tracing: Add event record param to trigger_ops.func() Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 04/10] tracing: Add get_syscall_name() Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 05/10] tracing: Add a per-event-trigger 'paused' field Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 06/10] trace: Add lock-free tracing_map Tom Zanussi
2015-06-12 18:17 ` Steven Rostedt
2015-06-29 20:19 ` Tom Zanussi
2015-06-12 20:47 ` Steven Rostedt
2015-06-12 20:52 ` Steven Rostedt
2015-06-29 20:33 ` Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 07/10] tracing: Add 'hist' event trigger command Tom Zanussi
2015-06-10 14:14 ` Masami Hiramatsu
2015-06-10 16:32 ` Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 08/10] tracing: Add enable_hist/disable_hist triggers Tom Zanussi
2015-06-08 21:32 ` [PATCH v7 09/10] tracing: Add 'hist' trigger Documentation Tom Zanussi
2015-06-08 21:32 ` [PATCH v3 10/10] ftrace: Add function_hist tracer Tom Zanussi
2015-06-10 2:57 ` [PATCH v7 00/10] tracing: 'hist' triggers Masami Hiramatsu
2015-06-11 3:05 ` Namhyung Kim
2015-06-11 20:42 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557BED8C.6050406@monom.org \
--to=wagi@monom.org \
--cc=andi@firstfloor.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome