From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3782676-1516711316-2-5612626559355811608 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='utf-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516711315; b=fk9w/5jJ8SMcsJ3wWJQa37qnTwhRUp3w9xq+kb2Iv+aKbrT 2Sncb5C2r/bYxB48vO5bESrye4b8gGGXQI8ArhoDAl1LCfFHQRDwglyGhObmqsWR uz4tZMBi1pnodf/OsHI+JzPiZuDSv/KW8Yxny8Uccf9vWKwWopjb6iYibyG4Bor8 A2pdfyW+DC6tolHGssSknn96PvkBhp0rf1DoM6mCebU24cT0jZ219l7UwY6QC80p J4sXVx0M74cDiDYq5s/0auJkAPwMKmFAnMTHxTcOp/lBrjwlcQDwLLAw+ebGX8kk xbINYe8BX2EwdXNiazrzs8yNsErE6sAb+WaNlhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1516711315; bh=emrH75ie0mUTJM/Z4dkrqO9qBwGiomQEo+AY9/aOR+A=; b=t 626gAjBq+GJs6yHqmkQMoNG820xKo+ln/nhwJTczcvR+7rI518o1vBpi8PZSHVK7 LJKKzii/HmVQfRFr0FLb726sRyPogKf1FDbjyt/huqxUSpUliB2oAJOrSyPTObcv nF7DUD3sGfWtaKiYcc6QAb193Ai6Io0x+V+cIEjhEoQfPm98gkEJ/8iW8pk1sZfX IN5vVYbskYYCqcK1+neu660u2tf43q5tW8h8Iur2hSqQM8AegsyK6E3x09X2Il82 hwv906SzeKbSKNQzmJlrTOF3fGkQUB3CIdaZDKHqeHO7B/sgAdZuqoBDd305i/Qd F2b/R+S7oEE7Je/MwwBRA== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=ti.com header.i=@ti.com header.b=uR0jYIud x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=ti-com-17Q1; dmarc=fail (p=quarantine,has-list-id=yes,d=quarantine) header.from=ti.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ti.com header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=ti.com header.i=@ti.com header.b=uR0jYIud x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=ti-com-17Q1; dmarc=fail (p=quarantine,has-list-id=yes,d=quarantine) header.from=ti.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ti.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751228AbeAWMl2 (ORCPT ); Tue, 23 Jan 2018 07:41:28 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:64754 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbeAWMl1 (ORCPT ); Tue, 23 Jan 2018 07:41:27 -0500 Subject: Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume To: Manu Gautam , CC: , References: <1516626103-1969-1-git-send-email-rogerq@ti.com> <1516626103-1969-3-git-send-email-rogerq@ti.com> <522f639a-466f-ae72-745e-61cbcc6fbfc7@codeaurora.org> From: Roger Quadros Message-ID: <557afc49-712d-9e70-7e4a-b7b3e74b7a50@ti.com> Date: Tue, 23 Jan 2018 14:41:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <522f639a-466f-ae72-745e-61cbcc6fbfc7@codeaurora.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Manu, On 23/01/18 05:45, Manu Gautam wrote: > Hi, > > > On 1/22/2018 6:31 PM, Roger Quadros wrote: >> Adding/removing host/gadget controller before .pm_complete() >> causes a lock-up. Let's prevent any dual-role state change >> between .pm_prepare() and .pm_complete() to fix this. > > What kind of lock-up are you seeing? Some hardware lockup or software deadlock? > IMO using a freezable_wq for drd_work should address that? > I was seeing a software deadlock. freezable_wq is a good idea. I'll try it out. > >> -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki