From: Marc Zyngier <marc.zyngier@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] PCI: shpchp: Manage SHPC unconditionally on non-ACPI systems
Date: Tue, 26 Jun 2018 09:01:04 +0100 [thread overview]
Message-ID: <557d863e-6ff9-b678-57a4-c26e4c5956f4@arm.com> (raw)
In-Reply-To: <152996758037.260522.6880919949506497973.stgit@bhelgaas-glaptop.roam.corp.google.com>
On 25/06/18 23:59, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> If acpi_pci_find_root() returns NULL, it means there's no ACPI host bridge
> device (PNP0A03 or PNP0A08), and the OS is always allowed to manage the
> SHPC, so return success in that case.
>
> This fixes a NULL pointer dereference when CONFIG_ACPI=y but the current
> hardware/firmware platform doesn't support ACPI. In that case,
> acpi_get_hp_hw_control_from_firmware() is implemented but
> acpi_pci_find_root() returns NULL.
>
> Fixes: 90cc0c3cc709 ("PCI: shpchp: Add shpchp_is_native()")
> Link: https://lkml.kernel.org/r/20180621164715.28160-1-marc.zyngier@arm.com
> Reported-by: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Marc Zyngier <marc.zyngier@arm.com>
Thanks for the quick turnaround!
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-06-26 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 22:59 [PATCH v1 0/4] PCI: shpchp: NULL pointer fix and cleanups Bjorn Helgaas
2018-06-25 22:59 ` [PATCH v1 1/4] PCI: shpchp: Manage SHPC unconditionally on non-ACPI systems Bjorn Helgaas
2018-06-26 8:01 ` Marc Zyngier [this message]
2018-06-25 22:59 ` [PATCH v1 2/4] PCI: shpchp: Separate existence of SHPC and permission to use it Bjorn Helgaas
2018-06-25 22:59 ` [PATCH v1 3/4] PCI: shpchp: Inline shpchp_is_native() Bjorn Helgaas
2018-06-25 23:00 ` [PATCH v1 4/4] PCI: hotplug: Implement hotplug_is_native() only when CONFIG_ACPI=y Bjorn Helgaas
2018-06-26 10:00 ` [PATCH v1 0/4] PCI: shpchp: NULL pointer fix and cleanups Mika Westerberg
2018-06-26 20:39 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557d863e-6ff9-b678-57a4-c26e4c5956f4@arm.com \
--to=marc.zyngier@arm.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®