From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032893AbeCAQ01 (ORCPT ); Thu, 1 Mar 2018 11:26:27 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:54530 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032868AbeCAQ0J (ORCPT ); Thu, 1 Mar 2018 11:26:09 -0500 X-Google-Smtp-Source: AG47ELvh0d0Xb6b7nV9rN5nUMrrlQslrOd4puA5t8EYcuc6QbmMRNEgTNDmvbiQ2QLc72IMdXKoUKA== Subject: Re: [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org References: <20180218220146.22485-1-hdegoede@redhat.com> <20180218220146.22485-9-hdegoede@redhat.com> <20180301162215.GC12864@sirena.org.uk> From: Hans de Goede Message-ID: <55819630-6198-6227-63ef-69311b21b255@redhat.com> Date: Thu, 1 Mar 2018 17:26:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180301162215.GC12864@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01-03-18 17:22, Mark Brown wrote: > On Sun, Feb 18, 2018 at 11:01:45PM +0100, Hans de Goede wrote: >> The ignore_suspend settings were added in an attempt to try and fix >> suspend / resume issues. But they never fully fixed these and now we've >> a proper fix, so lets remove these. > > Do these systems not have the ability to continue to play audio through > suspend using the DSP? That's the sort of thing that ignore_suspend is > normally used for. In theory yes, in practice if we keep ignore_suspend set then we get audio for a couple of more seconds after suspend until the buffers are empty, as we have no code keeping them filled, which is not really useful, since we don't support this in a meaningful way it is better to just do a normal full suspend. Regards, Hans