From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbdJAUFV (ORCPT ); Sun, 1 Oct 2017 16:05:21 -0400 Received: from mail-sn1nam01on0088.outbound.protection.outlook.com ([104.47.32.88]:64841 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750993AbdJAUFT (ORCPT ); Sun, 1 Oct 2017 16:05:19 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v4 05/29] crypto: ccp: Add Platform Security Processor (PSP) device support To: Borislav Petkov References: <20170919204627.3875-1-brijesh.singh@amd.com> <20170919204627.3875-6-brijesh.singh@amd.com> <20170929151607.zn4lmdkyn25sczfg@pd.tnic> <1fc76eee-f25b-cd38-cc8d-0404ec94cf79@amd.com> <20170930161104.452sia6a5y5duyn4@pd.tnic> From: Brijesh Singh Message-ID: <55879570-04d7-a627-5f4b-b94f1604ece5@amd.com> Date: Sun, 1 Oct 2017 15:05:11 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170930161104.452sia6a5y5duyn4@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR10CA0029.namprd10.prod.outlook.com (10.175.102.143) To CY1PR12MB0152.namprd12.prod.outlook.com (10.161.173.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07b821f4-47e4-4102-2649-08d50907bc95 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR12MB0152; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;3:GKMvZu5Ev5Ng1cpvHNKy20kNnuhYkCBNqMNRXn1I6/uY3etANJRm1RGKQBjJkJvT3/LqkptFsLk/nJpzPJK+kdNwlc/FtDkAVaRVsYOHZdnOXfZIHw/YXzmhM0UTFPUtRFAVo4drSmmhcNiKRkN1teaM9bd9pd8wQ/NprWdYpGY1CHsLGxzCJQ7vAKH8LmLLTgGPLX7tYMhwCwMW99hKjirMHHZCEa0k3WpeYIK3lvswscu4lbQFPRRFB8gM82rF;25:pBw4RdwpaKltFkjFqb1dXkrmMOQd0jT45bbV2jtKzMQ9tfYHpsmFQDReQOYOty/al+SXtv0vMmHUjdLqMrpfskp7IMe4rwOQUaG5niiPDryBTX7315Fw67fkS5rKVv5VkAPaRDNyrqpqxXHVNAAqn9LkSWzjPCU7TPDnVTzUM1JhgJATMwGh8/bglWbQE3JDRk/ti+ZFPkyS6KrU+LM2kOuchxrQPpcGPjMzxfo5dXffxkxz1VUP67khFB7qJayQqg95MHVjhMvG0XhHm/HpJvtqlMZHeufQXuJQX2OCV5+rI8U/iB87C1H64s51d6diEtCDn/zQoIKX96Eccnh7/g==;31:C9WaE9b7lKMo24heH887UBoi8kTbyQqzguv/JWdSuu7NNBZoBmaoIJ91wuw8xf5z+0MiNj4+CShPMcfPnYYoFLN729hp0p7T4qIo69Fjh8IJBj0mxTZdpVg/lhwjaEqb/sHRetG5JWH8xKz18eAHqWmsmCLR27EhpIJ9xjxcwZAOA0huswCXA4mIh39wzbAIraVs/7pa92iIHfZurwnzIOP8sV4TfNwp2ywiFxY0kPo= X-MS-TrafficTypeDiagnostic: CY1PR12MB0152: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:lfccmxFUSgcd4asJiqi8XJ0MQ3vs7nEpTS5Jjav1KmoJ7nywxQSbOKuWmJVQ8MiQJhXXEeCLbWe+R0yhrHD+7JA2DfjmwXL2HGR4HMomXFaed0pKFxWNQGVEyCShWV8o2fcC27QRfZ5J1uduYxq2wmf1+LLgLk3LgKGnY7Zh6AHDHF72txqvKMvnfwGsTOqwcmDjwL45b8h3maJOVcDvmRZYGKcHZx9Pa15p4ypA+ZHSprf6/iXYvtOLtSAyTFqN4bbzqPL/5DxD05Ju174ZLjO5ofdp6gcI10X2H7CJ5v5BbmZlkyuEe24NVy7Y+SETJ1wn6E2k7I+chWM0gOvUAWIru+l+xqjXMrB/eP7PbYXGucnjCfbJxKykA3mxoa47FbD11mlCeSQsaZHKEHqJYToiwPlX8hoWZ44MrWFFrHdRuCa95egfDdJEgyI7uOlTXZ4JLjrb4HZZW3cU/1PI/EF7IogwFVEFbQ3vRzXMYT7hDpXzxTQGb94H9uQ7m1rN;4:n9QUhCw/XUvQhWGAARiQ5ox7QoB2rnGOU+SOecMfjij+hzNsUYp1+fNgLVYJJcVYhrB92Ik9jXAVLoe3qc0rocsRxQEAehRry8HmRPJMgN0Rc/WpvVl/DIbHOnxMO7iZmXuXua87u7Or0MSg57xF7GsCkjZ8NAlDjPEBbujLmzPaiLvNIO/I7buUoT+hwWLiEMbV4vwPj9/Pp/k25xbnzCrAB93z4vOgsweICIXiKHbl790m/ufWA0eM03gMKJHZ4iDvibolz9mQLE7Dp51NyjLsNIS75ikbsSb/oixhalA= X-Exchange-Antispam-Report-Test: UriScan:(192374486261705); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123558100)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0152;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0152; X-Forefront-PRVS: 0447DB1C71 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(39860400002)(346002)(189002)(24454002)(377454003)(199003)(58126008)(478600001)(101416001)(25786009)(50986999)(76176999)(53936002)(2950100002)(54356999)(16526017)(6916009)(33646002)(2906002)(65956001)(86362001)(66066001)(5660300001)(230700001)(47776003)(31696002)(65826007)(64126003)(6246003)(316002)(83506001)(31686004)(65806001)(6116002)(8936002)(106356001)(54906003)(4326008)(23676002)(53416004)(81166006)(50466002)(3846002)(36756003)(6666003)(68736007)(7736002)(53546010)(229853002)(189998001)(8676002)(97736004)(81156014)(6486002)(305945005)(105586002)(93886005);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0152;H:wsp101095wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUyOzIzOlgvOGxPemZ5WlJzakdIZ1prQ3VGRFM5eVdU?= =?utf-8?B?VFI1VzJ6c25RRG15YXlxc2hCbkN6S2k3REVWZ0F5UXI4QWk2dW0rQUF3RTVH?= =?utf-8?B?M2NNSFRLZHBtQXRZd3MyNnJnVWFNV0VNSEFUcitSTjdzdk5TWThMalhnSVY2?= =?utf-8?B?TWtReHEvaHpsMFRHaEpEbmpoa3VnUFdlelhNVEFYR0ZWTUtLVlp3aFl1SjJH?= =?utf-8?B?elJZdXRjTzRhdVhXa1hvNHpHbDZkN0R2dUxkTUNHOE1Hd3F4dkRRbXp4TUZt?= =?utf-8?B?dEQvek1GSkcyN090am1wWUZJVStWTFpsYmVXWXhnbGdPMEdJdG15U1g5b1E0?= =?utf-8?B?VFBRb05EanBzalhiL1lTdFo0c2dGbTAyVUg5bWJ2VGp2WnJWWmwrMzFEOVlt?= =?utf-8?B?SzFyYU13b1ovaXhTNDFwN211cTBpdlVzdzVTKzJVT3Y4WVNmVHc4eTNyQXVm?= =?utf-8?B?eUlyTEFWMXkrVlNQUEQrSE1uUUQ0N1ArRUlzU3YyZ005eWJKWThtMXRrT1lH?= =?utf-8?B?VW84QUZENUxGNklhVW50bGhiRDZ2QWN0UFBnbmZLcE5jME4xTGpzQm1tdldU?= =?utf-8?B?RndVNTBqLzRXSGZTd2FxTWVoWUNkTG9QZll1dFZ1Q3ZldW9lZjdEcnhsZVZO?= =?utf-8?B?THdvbWhVMEFWVjhLLzl2M2VXWm9rd3YvK0dCUk1rSmFMYkV0NUFiRTNjQmZK?= =?utf-8?B?OCtSdWFjamVPR0dSdXlPSFpXVks0c0Jnc0h4U2Z6V0Izb0FMSmdCS3pCZDFx?= =?utf-8?B?Z09jNXo4dzg1d3ppNitLZmtmc3FDS0QreXpTMnJ3TWh6TmZ6U1prV2JxUldp?= =?utf-8?B?ODN0NDgrdmxqWENsUmdySWZSdDZmVTVPUXBFZWUyTkVVbDF3aUpvaStSUUUy?= =?utf-8?B?TjlCSTJlbHhlOGhqRXRuWFI0Tm5WNnVkT1RyZDhpL0NPVGdDbjZtWGtNWjZx?= =?utf-8?B?Y1l1c2xDSUQ2aUlBYXRlYlRyb2RVUXFqS0ZFdFdUTEJLSzlzelBNcXBXMlRU?= =?utf-8?B?QVdNU1paYTVqeGZqSDJpTHUwUlZnZU9GOE55OE56MndnRWttK3RnUkFGU2xH?= =?utf-8?B?UGd2TndIRUlrbjVBR1lIOUpZOGNiaWRlelBNUkpXVlRMbDdjUnVmWHdKVmJQ?= =?utf-8?B?NVloLzVmQ1ZYazFCMFZkeHpEN2ZEMnJjSmxQRSsyK1lmM0NpS3BxYWdOaWNJ?= =?utf-8?B?Mnc5MnNvd1gveTNZWmQxMjV0MExuQ1V5aHlnWjFTOEdTQzBBR21Uc0VsNVlG?= =?utf-8?B?TDV4OGFBSjkrQzR1WWtNRkZ5b1Z3c3VhcUE5RDc0emRVTmNYeS9ieGRyZzg0?= =?utf-8?B?emRUcVhUWVZuY3UzeXZ1bTFzRHJuZk1kbXY4Ly92aDVpbXRMZTdCNUVibkdk?= =?utf-8?B?TVdIMnIxTXI0VTgrUmdhM1JkYkNQK0hJN0dncTZma2UxR0hYQWQ0akxVSjht?= =?utf-8?B?Nk9teU1qVVJwY3dSd2RBbjZtOEVkdkZnaUZqWmFNVlNXNk9vV2xDa0c4YmMx?= =?utf-8?B?U1gxVDkrSEdKVTBlVDVoL0Y1elVsNVZOR2htcHZzUW5aOUxLVzBDRnA3SkQ5?= =?utf-8?B?TWFXSEJiK3YrVllUdUxZUHFYUGxUL2prNXlPOER0RlArVmM2c2QyVlZQamIr?= =?utf-8?B?cFVCZi9lV3RRdzBES090QTdKRGptTUI2czhrNTZLQ0dieW1vemtqY2R6U1VU?= =?utf-8?B?RFl5OGtnVEZ2dGNVQ0ozSXdYZTJxb2UrMzFjRVl2OUZ0SVExUldqL3hLVkYx?= =?utf-8?B?bnlMcXh5S2NSU0oxTXBDWHdGT056cUJCVzNlZ3UycXppSmtSdTB5ejRTbHNG?= =?utf-8?B?cWliak0zeWZ1aG1OdmNyQ0hyLzdsVWJIMU1tQVFZYW1iRjJxVjRkVFhKTUdO?= =?utf-8?Q?DHNDd7DQgIY=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;6:WF2J8ny6smI0dDpYdM4jugNVcRGZ5LbCl/25lpx7yMeR41vezOzAHmlZ1VipgPs44KfCNaqSNDC6YXROrLrohmin92Og5iEEv+ugWJabFn9lHgXKjLsmm+49ySLnXaEuupVGJlr/hWjqlN5oRGt6goaXwyisdI92y/oN/YsQqjGl3bGncXtiZxykoX4MpunlJKe+W4PpNaCuuooZCD/25jbHNSHMkxuwnJLHbsAQnNfB2aR2JfzdSfLD9z2ED+hn0BQBwjOlw+qQUZXRw7TPyGwB43Fe9CoMLccJUgVzvGH4unLNYvPUefiXVzlLTyoM9iHhTrO4s1H+BSJpqMcnog==;5:grvI0Ah0vzfqyOZmRA7USLnNkvNRmcpZo30XarXE9nMToFhsLLDKqrcjXnzdXveqPBuSAjebX0Dq0Mg/xwsXmwf543/uJ04Vuy2XvlyzVCq9Rq+HEwvXsjYOPjxALWrEzsUr5o8xEFxLyZghx5UfLw9waUBRXepUEafjx1Tatbk=;24:K22E+KorRduqkJuiIN55hsNGLBznK3q0OZ0nwX2K623tdLTBWf34UR9dtj+6KS1cy4N0S0AGurE5qbEH8DsR13nTCElna2btESGrTOgs5tY=;7:aVGb+4jj5lbNLVRDxWs8EyFFbdbnKFBn943JrmETp6yVmUfG0wFzTNyQlKivz7YoK6u4fNZ8YNm+0MxDUa0VLfwp8vnjLKgk4crR81guD5WWaLsApPyzdNU4zpNtZYAXg02+B9YfZmNyBViH8UOhQKVfFywzc0vV68k2b6Pmoex5x7SMWYEcwg6lfSDOiGPtmqhc5Hd4G1J1YBPh1XoMT0er7OPZy8/TJViQ/cwsim8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:Ob0WZbl8keW79pKOBtvmDzNYtknGIxqNwPE53o70IAPNxaqjPmH3Hc/IHVp2XCb7XByD7dKTK5Y9qfLxtdnIjaUeo94XmDW0jdop8LvJHIFANzkuTxGV6sWXWtF57GGgK7puQ3OUdZdixcjeu6eiyhHAUUqIRKSDSzkQUdoEhdfF6uOYGFjUTn7LWzrnoRmGmDw4HqSOSHTCeWnUf3UfFSqM+K4yzb3Nx1juYnGZJwcg/gJcIVR4AyLNf+i+/qhV X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2017 20:05:16.1573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/17 11:11 AM, Borislav Petkov wrote: > I think just from having CRYPTO_DEV_CCP_DD depend on CPU_SUP_AMD || > ARM64, CRYPTO_DEV_SP_PSP gets almost the same dependency transitively. > But sure, let's make the PSP build only on x86. It should depend on > X86_64, to be precise. I think theoretically a 32-bit host OS can invoke a PSP commands but currently PSP interface is exposing only the SEV FW command. And SEV feature is available when we are in 64-bit mode hence for now its okay to have depends on X86_64. I will add CRYPTO_DEV_CCP_DD depend on CPU_SUP_AMD || ARM64 and CRYPTO_DEV_SP_PSP depend on X86_64 and send you v4.2. thanks