mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: <david.vrabel@citrix.com>, <julien.grall@citrix.com>,
	<marcus.granado@citrix.com>, <Paul.Durrant@citrix.com>,
	<Rafal.Mielniczuk@citrix.com>, <roger.pau@citrix.com>,
	<xen-devel@lists.xenproject.org>, <justing@spectralogic.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising
Date: Tue, 23 Jun 2015 07:23:59 +0100	[thread overview]
Message-ID: <5589179F0200007800087E6E@mail.emea.novell.com> (raw)
In-Reply-To: <1434981360-29794-1-git-send-email-konrad.wilk@oracle.com>

>>> On 22.06.15 at 15:56, <konrad.wilk@oracle.com> wrote:
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -1951,6 +1951,8 @@ static void blkback_changed(struct xenbus_device *dev,
>  
>  	switch (backend_state) {
>  	case XenbusStateInitWait:
> +		if (dev->state != XenbusStateInitialising)
> +			break;

If, as you say in a subsequent reply, all other drivers already have
such a check, wouldn't it make more sense to put this into xenbus'
backend_changed() or even xenbus_otherend_changed()?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

  parent reply	other threads:[~2015-06-23  6:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03  5:40 [PATCH 1/3] drivers: xen-blkback: delay pending_req allocation to connect_ring Bob Liu
2015-06-03  5:40 ` [PATCH 2/3] driver: xen-blkfront: move talk_to_blkback to a more suitable place Bob Liu
2015-06-03  5:40 ` [PATCH 3/3] xen/block: add multi-page ring support Bob Liu
2015-06-09  8:50   ` Bob Liu
2015-06-09  8:52     ` Paul Durrant
2015-06-09 13:39       ` Konrad Rzeszutek Wilk
2015-06-09 13:48         ` Bob Liu
2015-06-09 14:07         ` Roger Pau Monné
2015-06-09 14:21           ` Konrad Rzeszutek Wilk
2015-06-19 20:12             ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-06-22  1:20           ` Bob Liu
2015-06-22 13:47             ` Konrad Rzeszutek Wilk
2015-06-22 13:56             ` [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising Konrad Rzeszutek Wilk
2015-06-22 14:06               ` Konrad Rzeszutek Wilk
2015-06-23  6:23               ` Jan Beulich [this message]
2015-06-23 11:57                 ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-06-23 12:51             ` [PATCH 3/3] xen/block: add multi-page ring support Marcus Granado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5589179F0200007800087E6E@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=Rafal.Mielniczuk@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=justing@spectralogic.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus.granado@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®