From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbbFYKCu (ORCPT ); Thu, 25 Jun 2015 06:02:50 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:61497 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbbFYKCn (ORCPT ); Thu, 25 Jun 2015 06:02:43 -0400 Message-ID: <558BD1B4.4030209@bfs.de> Date: Thu, 25 Jun 2015 12:02:28 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: SF Markus Elfring CC: Heiko Carstens , Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] s390/process: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558B1799.8040003@users.sourceforge.net> In-Reply-To: <558B1799.8040003@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 24.06.2015 22:48, schrieb SF Markus Elfring: > From: Markus Elfring > Date: Wed, 24 Jun 2015 22:40:30 +0200 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > arch/s390/kernel/process.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c > index dc5edc2..22e6448 100644 > --- a/arch/s390/kernel/process.c > +++ b/arch/s390/kernel/process.c > @@ -81,8 +81,7 @@ void release_thread(struct task_struct *dead_task) > > void arch_release_task_struct(struct task_struct *tsk) > { > - if (tsk->thread.vxrs) > - kfree(tsk->thread.vxrs); > + kfree(tsk->thread.vxrs); > } > > int copy_thread(unsigned long clone_flags, unsigned long new_stackp, maybe the intention was to check tsk != NULL ? re, wh