From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbbFYPFv (ORCPT ); Thu, 25 Jun 2015 11:05:51 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31475 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbbFYPFm (ORCPT ); Thu, 25 Jun 2015 11:05:42 -0400 Subject: Re: [PATCH v2 0/3] ARM: keystone: add ecc error interrupt handling To: Vitaly Andrianov , ssantosh@kernel.org, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org References: <1435242710-31346-1-git-send-email-vitalya@ti.com> From: santosh shilimkar Organization: Oracle Corporation Message-ID: <558C188B.5060107@oracle.com> Date: Thu, 25 Jun 2015 08:04:43 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1435242710-31346-1-git-send-email-vitalya@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/25/2015 7:31 AM, Vitaly Andrianov wrote: > This patch series adds support for arm L1/L2 ecc and ddr3 ecc error handling > for Keystone devices > > Change Log > > v2: > - removing unused and sorting headers of keystone.c are moved to a separate > patch. > - l1l2 ecc and ddr3 ecc error handling are split it to separate patches > - removed unused headers from keystone_ecc.c > - platsmp.c removed from the patch. > - return IRQ_HANDLED for 1 bit error in l1l2 ecc handler > - checked and handled existing ecc error before enabling ddr3 interrupt > - 1 bit ddr3 interrupt is disabled, because it is handled by hardware and > there is no reason to handle it by software > This version looks good to me. As already commented, I would have liked the patch 2/3(L2 ECC) code in ARM generic code so will give some more time for others to come back. Otherwise I will queue this up for next window. Thanks for follow up Vitaly. Regards, Santosh