From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
Vitaly Andrianov <vitalya@ti.com>
Cc: linux@arm.linux.org.uk, ssantosh@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: use phys_addr_t in pfn_to_kaddr()
Date: Thu, 25 Jun 2015 11:43:50 -0700 [thread overview]
Message-ID: <558C4BE6.20009@oracle.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1506251232050.2617@knanqh.ubzr>
On 6/25/2015 9:33 AM, Nicolas Pitre wrote:
> On Wed, 24 Jun 2015, santosh shilimkar wrote:
>
>> On 6/23/2015 8:13 AM, Vitaly Andrianov wrote:
>>> This patch fixes pfn_to_kaddr() to use phys_addr_t. Without this,
>>> this macro is broken on LPAE systems. For physical addresses above
>>> first 4GB result of shifting pfn with PAGE_SHIFT may be truncated.
>>>
>>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>>> ---
>> Looks a valid fix.
>>
>> RMK, Nico, what you say ?
>
> Looks fine to me.
>
> Acked-by: Nicolas Pitre <nico@linaro.org>
>
Thanks Nico.
Vitaly,
I suggest you to drop this patch into RMK's patch system with
mine and Nico's ack.
Regards,
Santosh
prev parent reply other threads:[~2015-06-25 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 15:13 Vitaly Andrianov
2015-06-24 19:22 ` santosh shilimkar
2015-06-25 16:33 ` Nicolas Pitre
2015-06-25 18:43 ` santosh shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558C4BE6.20009@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=ssantosh@kernel.org \
--cc=vitalya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome