From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbbFYVCU (ORCPT ); Thu, 25 Jun 2015 17:02:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34731 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbFYVCJ (ORCPT ); Thu, 25 Jun 2015 17:02:09 -0400 Message-ID: <558C6C4F.1090102@codeaurora.org> Date: Thu, 25 Jun 2015 14:02:07 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: santosh shilimkar , Vitaly Andrianov , ssantosh@kernel.org, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 0/3] ARM: keystone: add ecc error interrupt handling References: <1435242710-31346-1-git-send-email-vitalya@ti.com> <558C188B.5060107@oracle.com> In-Reply-To: <558C188B.5060107@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/25/2015 08:04 AM, santosh shilimkar wrote: > On 6/25/2015 7:31 AM, Vitaly Andrianov wrote: >> This patch series adds support for arm L1/L2 ecc and ddr3 ecc error >> handling >> for Keystone devices >> >> Change Log >> >> v2: >> - removing unused and sorting headers of keystone.c are moved to a >> separate >> patch. >> - l1l2 ecc and ddr3 ecc error handling are split it to separate patches >> - removed unused headers from keystone_ecc.c >> - platsmp.c removed from the patch. >> - return IRQ_HANDLED for 1 bit error in l1l2 ecc handler >> - checked and handled existing echttps://lwn.net/Articles/593336/c >> error before enabling ddr3 interrupt >> - 1 bit ddr3 interrupt is disabled, because it is handled by hardware >> and >> there is no reason to handle it by software >> > This version looks good to me. As already commented, I would have liked > the patch 2/3(L2 ECC) code in ARM generic code so will give some more > time for others to come back. Otherwise I will queue this up for next > window. Why not make this into an edac driver? I sent out an L1/L2 error detection edac driver for Krait processors a year ago, but it stalled due to some DT binding stuff[1]. This looks fairly similar. [1] https://lwn.net/Articles/593336/ -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project