From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: myungjoo.ham@samsung.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] extcon: arizona: Declare 3-pole jack if we detect open circuit on mic
Date: Fri, 26 Jun 2015 10:07:55 +0900 [thread overview]
Message-ID: <558CA5EB.5000807@samsung.com> (raw)
In-Reply-To: <1435247222-28821-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On 06/26/2015 12:47 AM, Charles Keepax wrote:
> Detecting an open-circuit on the microphone pin, usually means the
> headset has a microphone but the cable is faulty. Currently the code
> will simply stop detecting and declare nothing in this situation. It is
> better to declare this as headphones such that the user can still use
> their headset as plain headphones even if the microphone is faulty.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 4c47eb2..e216a97 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -829,7 +829,10 @@ static void arizona_micd_detect(struct work_struct *work)
> /* Due to jack detect this should never happen */
> if (!(val & ARIZONA_MICD_STS)) {
> dev_warn(arizona->dev, "Detected open circuit\n");
> + info->mic = false;
> + arizona_stop_mic(info);
> info->detecting = false;
> + arizona_identify_headphone(info);
> goto handled;
> }
>
>
Applied it.
Thanks,
Chanwoo Choi
prev parent reply other threads:[~2015-06-26 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 15:47 Charles Keepax
2015-06-26 1:07 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558CA5EB.5000807@samsung.com \
--to=cw00.choi@samsung.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome