From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbbF1Mji (ORCPT ); Sun, 28 Jun 2015 08:39:38 -0400 Received: from vi37-28-154-113.vibiznes.pl ([37.28.154.113]:59544 "EHLO vps-vb.mhejs.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbbF1Mjc (ORCPT ); Sun, 28 Jun 2015 08:39:32 -0400 Message-ID: <558FEAF3.8030308@maciej.szmigiero.name> Date: Sun, 28 Jun 2015 14:39:15 +0200 From: "Maciej S. Szmigiero" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Timur Tabi , "alsa-devel@alsa-project.org" CC: Nicolin Chen , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linuxppc-dev@lists.ozlabs.org, linux-kernel , Fabio Estevam Subject: Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode References: <558F28E1.7040204@maciej.szmigiero.name> <558F77B8.9060307@tabi.org> In-Reply-To: <558F77B8.9060307@tabi.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 28.06.2015 06:27, Timur Tabi pisze: > Maciej S. Szmigiero wrote: >> + if (newbinding && fsl_ssi_is_ac97(ssi_private)) { > > Is the "newbinding" necessary? I thought only the original PowerPC device trees were the only one that have the old binding, and they never supported AC97. If there isn't going to be new platforms added with old bindings then this won't be needed - I'll remove it. Best regards, Maciej Szmigiero