From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F50DC4708E for ; Wed, 28 Dec 2022 20:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231671AbiL1UcY (ORCPT ); Wed, 28 Dec 2022 15:32:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbiL1UcW (ORCPT ); Wed, 28 Dec 2022 15:32:22 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97B4F13D44; Wed, 28 Dec 2022 12:32:21 -0800 (PST) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BSKQ4vf001927; Wed, 28 Dec 2022 20:31:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=hPQ+xZA2/zQFK/5r/OYDYGZHuiZAzHLvGCCkk6+8BqU=; b=Tblo4UVL5I9f+H4Vyb9GQIhGdgvdzrX8xmD9rzwsOcptx1dRfxj8xn43qJDGkELahOxA ui+jjqhoYNbmY1Dib2K72bHWVcORa6sZPJGoJda+mU9u0hS7YUdBHwTMRloDuE5pJwsJ +7AjRwL27uIo+ZzlC4cB3KDT2hKKiLNfW92jn39zhlTJZ4gtulxpE5uWCSVXVSe6ZF20 Oa6uRAlRx9EGhESeEnKsQjZmIB7PTXM+1M72RA2bDxBpZi9AduV6m3NFT5MBJ8Ew2oLh /nmGXCwxXYVw1VaGZU5Wr98CHXxA+uATZibweArUWPSVKm17R5LHuWybafGr8ri0efl0 7Q== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mrp0yrt3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Dec 2022 20:31:19 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BSKVI3P031506 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Dec 2022 20:31:18 GMT Received: from [10.110.31.102] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 28 Dec 2022 12:31:17 -0800 Message-ID: <559030ff-112b-e0a8-b278-72f909724496@quicinc.com> Date: Wed, 28 Dec 2022 12:31:16 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 06/14] usb: core: hcd: Introduce USB HCD APIs for interrupter management Content-Language: en-US To: Alan Stern , Oliver Neukum CC: , , , , , , , , , , , , , , , , , , , References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-7-quic_wcheng@quicinc.com> From: Wesley Cheng In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: pNo8f1lNCunriSs5wwMKfDcH_pIE4amA X-Proofpoint-ORIG-GUID: pNo8f1lNCunriSs5wwMKfDcH_pIE4amA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-28_15,2022-12-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=346 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212280176 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan, On 12/28/2022 7:16 AM, Alan Stern wrote: > On Wed, Dec 28, 2022 at 09:59:03AM +0100, Oliver Neukum wrote: >> >> >> On 27.12.22 22:07, Wesley Cheng wrote: >> >>> >>> Hmmm...maybe I should change the name of the API then to avoid the confusion.  Yes, usb_hcd_flush_endpoint() does ensure that URBs submitted to the EP are stopped.  However, with this offloading concept, we aren't actually submitting URBs from the main processor, so the ep->urb_list will be empty. >>> >>> This means the usb_hcd_flush_endpoint() API won't actually do anything.  What we need is to ensure that we send a XHCI stop ep command to the controller. >> >> That is a concept specific to XHCI, yet you are adding a generic >> API. The namin should reflect that. usb_quiesce_endpoint() ? > > Or even xhci_send_stop_ep_cmd(), which is what the routine is intended > to do. > Just to clarify, you're talking about renaming the API that was added in the XHCI driver, correct? Thanks Wesley Cheng