From: Eric Auger <eric.auger@linaro.org>
To: jroedel@suse.de, Will Deacon <Will.Deacon@arm.com>,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
Alex Williamson <alex.williamson@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Regression observed since "iommu: Propagate error in add_iommu_group" with arm-smmu
Date: Mon, 29 Jun 2015 14:46:46 +0200 [thread overview]
Message-ID: <55913E36.4010407@linaro.org> (raw)
Hi Joerg, Will
I observe a regression since commit
19762d7095e6392b6ec56c363a6f29b2119488c2 (iommu: Propagate error in
add_iommu_group) with arm-smmu: I am not able to bind the vfio-platform
driver to one Calxeda Midway xgmac anymore. This latter is not assigned
any group.
Looks like the cause is, in iommu_bus_init, when doing
bus_for_each_dev(bus, NULL, &cb, add_iommu_group),
add_iommu_group fails for some devices which are not upstream to smmu
and enumerated before the xgmac. As a consequence bus_for_each_dev
returns without looking at the xgmac.
arm_smmu_add_platform_device currently returns -ENODEV when no smmu/no
master port for the device. Shouldn't we return 0 now?
Thank you in advance
Best Regards
Eric
19762d7095e6392b6ec56c363a6f29b2119488c2 is the first bad commit
commit 19762d7095e6392b6ec56c363a6f29b2119488c2
Author: Joerg Roedel <jroedel@suse.de>
Date: Thu May 28 18:41:26 2015 +0200
iommu: Propagate error in add_iommu_group
Make sure any errors reported from the IOMMU drivers get
progapated back to the IOMMU core.
Signed-off-by: Joerg Roedel <jroedel@suse.de>
next reply other threads:[~2015-06-29 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 12:46 Eric Auger [this message]
2015-06-29 13:16 ` Joerg Roedel
2015-06-29 13:32 ` Eric Auger
2015-06-29 13:43 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55913E36.4010407@linaro.org \
--to=eric.auger@linaro.org \
--cc=Will.Deacon@arm.com \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®