Re: [PATCH v2 5/8] net: ethernet: sis900: Use pure PCI devres API

[Daniele Venzano <venza@brownhat.org>]

On 25/04/2025 10:57, Philipp Stanner wrote:
> The currently used function pci_request_regions() is one of the
> problematic "hybrid devres" PCI functions, which are sometimes managed
> through devres, and sometimes not (depending on whether
> pci_enable_device() or pcim_enable_device() has been called before).
>
> The PCI subsystem wants to remove this behavior and, therefore, needs to
> port all users to functions that don't have this problem.
>
> Replace pci_request_regions() with pcim_request_all_regions().
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Daniele Venzano <venza@brownhat.org>
> ---
>   drivers/net/ethernet/sis/sis900.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
> index 332cbd725900..df869f82cae8 100644
> --- a/drivers/net/ethernet/sis/sis900.c
> +++ b/drivers/net/ethernet/sis/sis900.c
> @@ -468,7 +468,7 @@ static int sis900_probe(struct pci_dev *pci_dev,
>   	SET_NETDEV_DEV(net_dev, &pci_dev->dev);
>   
>   	/* We do a request_region() to register /proc/ioports info. */
> -	ret = pci_request_regions(pci_dev, "sis900");
> +	ret = pcim_request_all_regions(pci_dev, "sis900");
>   	if (ret)
>   		goto err_out;
>