From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489743BD629 for ; Fri, 22 May 2026 09:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779442286; cv=none; b=mfi5siGkTEYiKagA9coCW1gVX+aoRJdqJ4brypO3CdQvxT4XiB1AyAXXirDGeNlnMCB/WQ7aAvZQV29gKQzaA9ei7sY2zEAKjhXyM+U+BedHk/9Vvrqjxul12Z2tmBoCHDWp9k1TDEDDZA4pI0MlvYiY2+L6QKhz+i08VDUuPY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779442286; c=relaxed/simple; bh=ReQQM/7igDEjQztdU+albgNOdhmDe20jo44TvforNaY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hjRZwWiTu7VwXjtcri8xiHSixLbsnRfQXAhpu7082v6K4Srp1RTp1r70zd7ELVvBt1yAwu4K2TAEhjrE1TIqOy2YjlmTanFOLOGhDh0z3YTOQT7/T6+1NXtSoG96ogQUlZLK90RAErD/fjZ6/31HvRdzEgbYFMC+nTKMJT5UHrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YHicWvgI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=busEow4t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YHicWvgI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="busEow4t" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M93saw1816063 for ; Fri, 22 May 2026 09:31:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CmuyIiSD8BrtuoCQP+CAPpqrC+rs5hG3BsCae1P/mCs=; b=YHicWvgIi1t1p7dy a53VKRNrD/g7G30Spr4USby0aatZy/IbRFe86lZr31rcihEBfAhGBsSRRmeQ4I/0 SgHEuUunAOE+sXrQO2oH6dFz+vkG4JzXFDQQYihTv8m8EczHzOKkvXArQhrIWC/K 5IBg/PzZy/m0W5HYfV3LcNk/CBwvUO2+3EJFMqq1elHuVY9dMmMp8vjqoKHtyx3B rIdTEeMCrcAcw0u9xWXsagl0W4xJ8O9hiX+Lk816HvLR1WVElA2+M7sppAZoj9U6 JEKE0PUXNER/UnrSTAcI1+dOF9IUgJfB1bZXVEPUWoNlnZsyqsogdoPSFrUJvFQN 6DOXYA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eafrm1ax2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 09:31:24 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-369ef27fd09so5405028a91.3 for ; Fri, 22 May 2026 02:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779442283; x=1780047083; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CmuyIiSD8BrtuoCQP+CAPpqrC+rs5hG3BsCae1P/mCs=; b=busEow4too8KLMDLtIrekVpmW6IXdJMcI0BxOfmPL3EcDLj5zN6pYox11/fFP55Pq8 FOtJ6p19sgRWARmuqCc6kU6lGpuQuRGxOLiIMyVqnu5HhMFqQOfGd/HkJtScF/Poahqg CO+etRpczQj0RAxCbQa9yuO1yIBdPQh0TaHo7lUWSEEVGHtBuf3UwuopIg1weBQzEJVk VCgEhzv05dMDg5nZGHHnE4tAIgMBVfVIX9hjAcWwaaRG8c26vx+/KZZtaS3CbEMMDSdf fq9L94MsAl8XDBSfZOGm0xbX77zdyOSqXnhw6EQ/umeok6w/84h90mtJH7Ub01CEoJ5q xV9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779442283; x=1780047083; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CmuyIiSD8BrtuoCQP+CAPpqrC+rs5hG3BsCae1P/mCs=; b=SoOywTMqw45RFoVE9Yzz5enYesPMb9aA/yiqwpM9msnGFsDnjCHKZfjj3jTgaSLIIA o54uN68kRRBkHTN7YftWLjcgHWUkWm/WZ7BtnHrfMiLrbZtomy4HBIHgATj89RL3TJOA oUOuLyq3IHOmb0aDwSS78dh3LFMwJ3H45i1WlbxoPQBUpJI0MLJ6heRQFiFJNcyLtIuF e/ol+oX0UBqvEoIKKt68Q4bQ2sV7t4mJQ3yRZmOP1B95er4capoDHVRPTvm9yzwJmEYL EX2SJAhjwVrmmviAvVHfHqt1vPj0jg3qzqLOCvi2D0E/E3XE6JLRuv+IRZuOUgNmSGVC YFMA== X-Forwarded-Encrypted: i=1; AFNElJ+6MtMv/f5j9ipPNMlXeYDGHGi/kmYejQc5V1dMDNCrmdoeGxLpqnfrIDJJsgm1DntfqSKs/ZovbzKbQnI=@vger.kernel.org X-Gm-Message-State: AOJu0YxA6sfSlFNCHEc9PV8HiRGEOINgKnrnQjC9j3QhFs7iM4RN41nn a0KTeHqHRNaZ+uTkoUVhv+JOwFXEzCQlfd1HgixxgswjrOOsNYb4CL4DY5fW1oQ0bZ7FLXZbmM2 uTgsp/w6rX70Ymdc3UABrKYJbLHiMgkh5qmNkkjr+Rm8ZB02vHLVBo7Uj7u3qUBpVFjM= X-Gm-Gg: Acq92OGt9Lu6v141aoXe6m7uEaJQzam0/hrUEFTDS+I+Uk8ddfOqInJAgOgHcsvWWtc B1r4hx/1yYo1xTidIqL5P0QSUW222aRUlNbI9j2ALYC77dJu80D8iHUDr5OWsny1Nj7L1JfGLn0 NAw47NvuFVqBaFq4VhcOtSS12zFZIey+Y4FCN4BJeMfZ5A9CDFIfBtrdcn30b82tz6QtVxa4HFA 5nsG5Sikt3VUkMU1HccBajgDFdnnQY7Wf286wsVYKcTDx2RlBL1AZjnqObSna60uGPMk5c3aD3I Tkjx0WPZ1E0YS84ueJ7RBuJ1vSEgcAKWX8F8JEuCbW8I2ECDqi4HvviqQkVHM92jbVKKAlEM4k/ Zx99r1QmmoWmY4o6UwWsR/Ru5scJfbbEoEhCoGg/BSCba1spYzj2KjuTuPUCkiwcx X-Received: by 2002:a17:90b:2584:b0:368:6159:980c with SMTP id 98e67ed59e1d1-36a676276b9mr2733221a91.20.1779442283321; Fri, 22 May 2026 02:31:23 -0700 (PDT) X-Received: by 2002:a17:90b:2584:b0:368:6159:980c with SMTP id 98e67ed59e1d1-36a676276b9mr2733193a91.20.1779442282825; Fri, 22 May 2026 02:31:22 -0700 (PDT) Received: from [10.92.193.94] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a6772f486sm936162a91.2.2026.05.22.02.31.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 02:31:22 -0700 (PDT) Message-ID: <5593d136-569e-4ba9-9a2f-e635125899aa@oss.qualcomm.com> Date: Fri, 22 May 2026 15:01:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] PCI: qcom: Add Support for Eliza To: Krzysztof Kozlowski Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20260521-eliza-v1-0-97cdbe88389d@oss.qualcomm.com> <20260521-eliza-v1-3-97cdbe88389d@oss.qualcomm.com> <20260522-discerning-sympathetic-moth-daa9e7@quoll> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <20260522-discerning-sympathetic-moth-daa9e7@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Up01yoXnXXuW8qgV8DS1LPFU4_J2odlx X-Authority-Analysis: v=2.4 cv=Zekt8MVA c=1 sm=1 tr=0 ts=6a10226c cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=jbukJSVhv8iEu2CO0E0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA5NCBTYWx0ZWRfX6ckIHghjzOtJ lzoZd0HqARe83N1DuscfmxlN2SS5AdUjr3aZu1j5DqpO8s8PmnfSq+PaWghMajoTZn3KW6oJUB0 MtCbWxDBv9u9IsoUjI8yyt+HGCEHPkxqKJSMTV+9rXXzGIecMqsP1ZRUcT9aiAj/Yc7XfBSSHnb PFePFOPSdi+djN0kwXrwJHwtHiw46oVl5RIZ94Ng2YCRpkDqFFFVfmczZIS3XAGlx0F/mMbOTu3 JflbF45zF3u5R9CFOxSQxpANTg6N3PA+eTC+gJG+untY1sVZfY3MZEUMvRpN1gn7/modfpu0vEt v4PD2HM0A6yB16kW1Nu6TfuaAiezwyl9h0CHFUTxWzFQjxgJAhtvxIH9IcB/h8hz3Dr6mC0tI5M QmQfsE2/h9vq+Sen2NWeqN08FG7agl11/Vz0pI6GY0Ibt4KEifUDujOGE2jGmA9Sj6uiWRFU8wL qq7rQIomNQrDrg9CIpw== X-Proofpoint-GUID: Up01yoXnXXuW8qgV8DS1LPFU4_J2odlx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220094 On 5/22/2026 12:21 PM, Krzysztof Kozlowski wrote: > On Thu, May 21, 2026 at 07:35:31PM +0530, Krishna Chaitanya Chundru wrote: >> Add support for Eliza soc, which has two PCIe controllers capable >> of 8GT/s X1 and 8GT/s X2, using the cfg_1_9_0 configuration. >> >> Signed-off-by: Krishna Chaitanya Chundru >> --- >> drivers/pci/controller/dwc/pcie-qcom.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c >> index af6bf5cce65b..40f0a5f247eb 100644 >> --- a/drivers/pci/controller/dwc/pcie-qcom.c >> +++ b/drivers/pci/controller/dwc/pcie-qcom.c >> @@ -2123,6 +2123,7 @@ static int qcom_pcie_resume_noirq(struct device *dev) >> static const struct of_device_id qcom_pcie_match[] = { >> { .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 }, >> { .compatible = "qcom,pcie-apq8084", .data = &cfg_1_0_0 }, >> + { .compatible = "qcom,pcie-eliza", .data = &cfg_1_9_0 }, > So compatible with sm8550. Why isn't this explained in commit msg of > the binding? No, PCIe controller is not compatible with sm8550, we are just re using the boot sequence used by the sm8550. > Anyway, drop the change, pointless. Look how other devices handle this - > do you see kaanapali here? No. As we are going to use different dts schema for this controller we can't really re-use like how we have done in kaanapali case.  kaanpali is reusing sm8550 schema, where this controller can't use sm8550 schema, as some clocks are different. - Krishna Chaitanya. > > Best regards, > Krzysztof >