From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ray Liu <ray.liu@airoha.com>, Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Andreas Gnau <andreas.gnau@iopsys.eu>
Subject: Re: [PATCH RESEND v5 03/13] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler
Date: Wed, 1 Oct 2025 13:34:13 +0200 [thread overview]
Message-ID: <55975f94-3655-480c-be9e-ac4075c60a7d@collabora.com> (raw)
In-Reply-To: <20250930022658.1485767-4-mikhail.kshevetskiy@iopsys.eu>
Il 30/09/25 04:26, Mikhail Kshevetskiy ha scritto:
> Booting without this patch and disabled dirmap support results in
>
> [ 2.980719] spi-nand spi0.0: Micron SPI NAND was found.
> [ 2.986040] spi-nand spi0.0: 256 MiB, block size: 128 KiB, page size: 2048, OOB size: 128
> [ 2.994709] 2 fixed-partitions partitions found on MTD device spi0.0
> [ 3.001075] Creating 2 MTD partitions on "spi0.0":
> [ 3.005862] 0x000000000000-0x000000020000 : "bl2"
> [ 3.011272] 0x000000020000-0x000010000000 : "ubi"
> ...
> [ 6.195594] ubi0: attaching mtd1
> [ 13.338398] ubi0: scanning is finished
> [ 13.342188] ubi0 error: ubi_read_volume_table: the layout volume was not found
> [ 13.349784] ubi0 error: ubi_attach_mtd_dev: failed to attach mtd1, error -22
> [ 13.356897] UBI error: cannot attach mtd1
>
> If dirmap is disabled or not supported in the spi driver, the dirmap requests
> will be executed via exec_op() handler. Thus, if the hardware supports
> dual/quad spi modes, then corresponding requests will be sent to exec_op()
> handler. Current driver does not support such requests, so error is arrised.
> As result the flash can't be read/write.
>
> This patch adds support of dual and quad wires spi modes to exec_op() handler.
>
> Fixes: a403997c12019 ("spi: airoha: add SPI-NAND Flash controller driver")
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2025-10-01 11:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 2:26 [PATCH RESEND v5 00/13] spi: airoha: driver fixes & improvements Mikhail Kshevetskiy
2025-09-30 2:26 ` [PATCH RESEND v5 01/13] spi: airoha: return an error for continuous mode dirmap creation cases Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 02/13] spi: airoha: remove unnecessary restriction length Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 03/13] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno [this message]
2025-09-30 2:26 ` [PATCH RESEND v5 04/13] spi: airoha: remove unnecessary switch to non-dma mode Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 05/13] spi: airoha: switch back to non-dma mode in the case of error Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 06/13] spi: airoha: fix reading/writing of flashes with more than one plane per lun Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 07/13] spi: airoha: unify dirmap read/write code Mikhail Kshevetskiy
2025-09-30 2:26 ` [PATCH RESEND v5 08/13] spi: airoha: support of dualio/quadio flash reading commands Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 09/13] spi: airoha: avoid setting of page/oob sizes in REG_SPI_NFI_PAGEFMT Mikhail Kshevetskiy
2025-09-30 2:26 ` [PATCH RESEND v5 10/13] spi: airoha: reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 11/13] spi: airoha: set custom sector size equal to flash page size Mikhail Kshevetskiy
2025-10-01 11:34 ` AngeloGioacchino Del Regno
2025-09-30 2:26 ` [PATCH RESEND v5 12/13] spi: airoha: avoid reading flash page settings from SNFI registers during driver startup Mikhail Kshevetskiy
2025-09-30 2:26 ` [PATCH RESEND v5 13/13] spi: airoha: buffer must be 0xff-ed before writing Mikhail Kshevetskiy
2025-10-01 11:30 ` AngeloGioacchino Del Regno
2025-10-01 22:13 ` Mikhail Kshevetskiy
-- strict thread matches above, loose matches on Subject: below --
2025-09-17 21:58 [PATCH RESEND v5 00/13] spi: airoha: driver fixes & improvements Mikhail Kshevetskiy
2025-09-17 21:58 ` [PATCH RESEND v5 03/13] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler Mikhail Kshevetskiy
2025-09-04 14:23 [PATCH RESEND v5 00/13] spi: airoha: driver fixes & improvements Mikhail Kshevetskiy
2025-09-04 14:23 ` [PATCH RESEND v5 03/13] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler Mikhail Kshevetskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55975f94-3655-480c-be9e-ac4075c60a7d@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andreas.gnau@iopsys.eu \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=ray.liu@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®