From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CC4E42188A for ; Mon, 2 Mar 2026 16:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468993; cv=none; b=AUBHYxiUsprMsYA29h145TWsrsdnlKDTX7xMT6qQiOp8umsVbc4DWAtf2Ds0umiLjSVngjtawZKHbkdYIXZ18ReFsd2WQ4O8K0K+f0KGC8Ungng5I44SAoXcH9TLKIIcPnZVj7v3+qXpjvBR/q147FqX7ksQEC1u+zR4hGqv/YE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468993; c=relaxed/simple; bh=iHC3/jsZXpJKhdI5OSw+muYX37DTgSKILkeyl4flMUc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uHwweZfLqcUBo8o4KMECejobm/Fnx3spbEJnOX28P49NesXDEuMd/xe6iq+FfvZcZbGy9doOmx9hFPunX5uw3bGH8xaS7JZ7336cewPO4toHxaecOUMs9TNyzHwvbFA3reKbU6YsXEsV2oE/41TLD/yN9hhsW3EJcwov4At1rK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=imu64pB/; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="imu64pB/" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7d4b9c839b1so2441119a34.1 for ; Mon, 02 Mar 2026 08:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772468991; x=1773073791; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nZW0nGDoaKxPbtsphSFQSsDtmOgBp9+Z7W8ytSm8fwk=; b=imu64pB/GS3OB+29FiT+TCOZ+VtMOAluxiEyqBfyyVTBTRhcnGtY533yB3wvPXqPyv /Dzbf94seNbfIUcqDT7gyS5+c8AZLj9q0oA7EfjzM50LJIf+BOus4LHnjYnUuIgvwDds KX09Z7Fb/JQ+yUwvRt8K03bjlg2UwGm3sDxEjW44EswAVHLt+mGebMPbtwZzzuedQH0z lxKQiWA5DgHiVWZ2t5pSBEiTxv1SiaTPXZ1PpQ/osng3hgV2+D/BQAbkBWhINBhMOwyE yGdraN8i4eX5GdQdk1CITq0MwZgqIs3gLo4T+Q+ud2cv1ZJ0uxxz1ho/urncpZeIbuj7 o1+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772468991; x=1773073791; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nZW0nGDoaKxPbtsphSFQSsDtmOgBp9+Z7W8ytSm8fwk=; b=SJfVULH/W8MYs05bT+uFz1xtuDPv33aPkxwFlcSxlixvM6yZF9JEEaqBTd0DCy5KFs 0lZ7V9MVaftUw7JmxaTV+/ZL5rUFWfFKYFigZEO9VfZEpwYG9tK8gzWIjV/NOw1ZDXbJ FGEkawTCFfkRtsBUxlW3AKRlLErIzUkRBeVDLqXBJJXQ5WjEsnrawyGv3Be9HxEiQZZn 8VnAwMWDxjv+ABxl4uIOXRrPqPTTY+M6AcA2EZ0rI7Hq7iJJLZUETLs17gmMtYOXB9BY RgqJpCnLA+6qfH82SZt8+Lqa+BjZKsB9VBOyMSXQhgbuoaw2RiIrPwNO0Uc78E1okEZr oFaw== X-Forwarded-Encrypted: i=1; AJvYcCWbLUkl0E7yGHQ2j1dUJsAQuHE57wN1SLh2t/uxDAf+8KDNUgq6nb35NSnoE5KEKSQkyLKllg01lvFH1i0=@vger.kernel.org X-Gm-Message-State: AOJu0YxmdqW5YYDKR6SkZz7vU+GznKd1+pMJKFCFJ7bluKfFzoHMRONo Sp+LSY9bUv1nVdpBui2Sy2wThr73KwtQYHzWq+SLEojMsw/k172g+3H6VdKnyA4cJoM= X-Gm-Gg: ATEYQzw8tnKY6j0ih/53tBUXXfu1v1ZBIG76sVdVrKKOIakLzXaa6WLxJhSJ96Lmqqk upcMD9Ui4LlGcrNiNmj/6Q6h3gAxcAVHq6K6joB/QofzUScp/uwzcNPjxN+OuW0gk2hi1qcUITx 64m5tHlEIGrBZfcLheAB1eXGm1ds2d/2OGpwFuF8nSHQfmc2+ZVyD+n/UYgftHPH12fXcWTYmyb zOeFafXvWrnK1XKNMp98oN3y8EpO3EHtAtFYLANFlfiShZBqSQcTA+K4iStzlbCT4eyYBBl2v1n nzcfQuYIiPmR/ay1zEt8yOXFhLjvDWBpQ6WDD58b7drFbngI0TxEEg88bGN87tftr75G8a55oxj ynEcJyhz5QQM2vqL2I0XPa8bCp/mRMNULNAnAjqGbX3QD3X9H4VLYqOuOlXBXcKt7aS0Z3/u/mz 9rBXvro2aO989H76/7kBKeblxW3tuqlS04s0IDtM/cJv4lqHoJlfU1+5/QxWjmYZnQWU0ezbRPg Q== X-Received: by 2002:a05:6820:199a:b0:679:f0ec:427d with SMTP id 006d021491bc7-679fadbf675mr7650067eaf.13.1772468991085; Mon, 02 Mar 2026 08:29:51 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:4c09:7c6b:bc48:f2f7? ([2600:8803:e7e4:500:4c09:7c6b:bc48:f2f7]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-679f2be9b8bsm9387127eaf.5.2026.03.02.08.29.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 08:29:50 -0800 (PST) Message-ID: <5599f271-3d81-460c-b2f3-3cbd704ffbdf@baylibre.com> Date: Mon, 2 Mar 2026 10:29:49 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] iio: adc: ad799x: make rx_buf static and DMA-safe To: Archit Anant , jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com Cc: nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260302130632.29144-1-architanant5@gmail.com> <20260302130632.29144-2-architanant5@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260302130632.29144-2-architanant5@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/2/26 7:06 AM, Archit Anant wrote: > Currently, rx_buf is dynamically allocated using kmalloc() every time > ad799x_update_scan_mode() is called. This can lead to memory leaks if > the scan mask is updated multiple times. > > Drop the dynamic allocation and replace it with a static, buffer at the > end of the state structure using IIO_DECLARE_DMA_BUFFER_WITH_TS(). > This eliminates the allocation overhead, prevents leaks, and removes > the need for manual kfree() on driver removal. > See replies in v1 and v2. DMA-safe is not important because it is I2C.