From: Roger Quadros <rogerq@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
<linux-input@vger.kernel.org>
Cc: Jianchun Bian <jcbian@pixcir.com.cn>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] Input: pixcir_i2c_ts - simplify input device initialization
Date: Tue, 7 Jul 2015 14:39:36 +0300 [thread overview]
Message-ID: <559BBA78.7010503@ti.com> (raw)
In-Reply-To: <1436229011-29655-5-git-send-email-dmitry.torokhov@gmail.com>
On 07/07/15 03:30, Dmitry Torokhov wrote:
> input_mt_init_slots() will perform necessary settings for performing
> multi-touch to single-touch emulation, we do not need to do that ourselves.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index 9d9ac08..043d219 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -510,11 +510,6 @@ static int pixcir_i2c_ts_probe(struct i2c_client *client,
> input->close = pixcir_input_close;
> input->dev.parent = &client->dev;
>
> - __set_bit(EV_KEY, input->evbit);
> - __set_bit(EV_ABS, input->evbit);
> - __set_bit(BTN_TOUCH, input->keybit);
> - input_set_abs_params(input, ABS_X, 0, pdata->x_max, 0, 0);
> - input_set_abs_params(input, ABS_Y, 0, pdata->y_max, 0, 0);
> input_set_abs_params(input, ABS_MT_POSITION_X, 0, pdata->x_max, 0, 0);
> input_set_abs_params(input, ABS_MT_POSITION_Y, 0, pdata->y_max, 0, 0);
>
>
next prev parent reply other threads:[~2015-07-07 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 0:30 [PATCH 1/6] Input: pixcir_i2c_ts - move platform data Dmitry Torokhov
2015-07-07 0:30 ` [PATCH 2/6] Input: pixcir_i2c_ts - switch the device over to gpiod Dmitry Torokhov
2015-07-07 10:55 ` Roger Quadros
2015-07-07 0:30 ` [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders Dmitry Torokhov
2015-07-07 10:55 ` Roger Quadros
2015-07-07 0:30 ` [PATCH 4/6] Input: pixcir_i2c_ts - add RESET gpio Dmitry Torokhov
2015-07-07 0:30 ` [PATCH 5/6] Input: pixcir_i2c_ts - simplify input device initialization Dmitry Torokhov
2015-07-07 11:39 ` Roger Quadros [this message]
2015-07-07 0:30 ` [PATCH 6/6] Input: pixcir_i2c_ts - use standard OF touchscreen parsing code Dmitry Torokhov
2015-07-07 11:47 ` Roger Quadros
2015-07-07 10:46 ` [PATCH 1/6] Input: pixcir_i2c_ts - move platform data Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559BBA78.7010503@ti.com \
--to=rogerq@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jcbian@pixcir.com.cn \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome