From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbbGJHSD (ORCPT ); Fri, 10 Jul 2015 03:18:03 -0400 Received: from www.linutronix.de ([62.245.132.108]:45259 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752520AbbGJHRy (ORCPT ); Fri, 10 Jul 2015 03:17:54 -0400 Message-ID: <559F7193.7090508@linutronix.de> Date: Fri, 10 Jul 2015 09:17:39 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Pavel Machek , Greg KH , balbi@ti.com, george.cherian@ti.com, tony@atomide.com, varkabhadram@gmail.com, linux-kernel@vger.kernel.org CC: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, linux-arm-kernel , linux-omap@vger.kernel.org, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com Subject: Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs References: <20150709213922.GA32698@amd> <20150709214610.GA20890@amd> In-Reply-To: <20150709214610.GA20890@amd> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2015 11:46 PM, Pavel Machek wrote: > On Thu 2015-07-09 23:39:22, Pavel Machek wrote: >> Hi! Hi, >> >> sysfs should contain one value per file. This one has at least two, >> with nice english sentence as a bonus. >> >> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto# >> cat vbus >> Vbus off, timeout 1100 msec >> >> :-(. > > Plus, documentation for this is nowhere to be seen: > > pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/ > pavel@amd:/data/l/linux-n900$ that is a shame indeed. It is part of the driver since TUSB support was merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7 years ago. The parameter expects the timeout values which is used to poll the port for mode changes (host/device mode) since it can not be detected on its own. Felipe knows best if it is better to document it or remove it. I can't remember that I needed it on am335x. > Pavel > Sebastian