From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: vgoyal@redhat.com, linux-kernel@vger.kernel.org,
avanzini.arianna@gmail.com, kernel-team@fb.com
Subject: Re: [PATCHSET block/for-linus] blkcg: blkcg_policy_data fixes
Date: Fri, 10 Jul 2015 08:28:22 -0600 [thread overview]
Message-ID: <559FD686.2000306@kernel.dk> (raw)
In-Reply-To: <1436474390-3762-1-git-send-email-tj@kernel.org>
On 07/09/2015 02:39 PM, Tejun Heo wrote:
> During 4.2-rc1 merge window, e48453c386f3 ("block, cgroup: implement
> policy-specific per-blkcg data") got merged. It had several bugs and
> a322baad1003 ("block/blk-cgroup.c: free per-blkcg data when freeing
> the blkcg") fixed one of them but there are still a couple remaining.
>
> * blkcg_policy[] iteration during css_alloc isn't protected.
>
> * Lazy allocation scheme is broken and policy data may be missing or
> an old policy data may get reused by the wrong policy.
>
> This patchset contains the following four patches to fix the above
> issues.
>
> 0001-blkcg-allow-blkcg_pol_mutex-to-be-grabbed-from-cgrou.patch
> 0002-blkcg-blkcg_css_alloc-should-grab-blkcg_pol_mutex-wh.patch
> 0003-blkcg-implement-all_blkcgs-list.patch
> 0004-blkcg-fix-blkcg_policy_data-allocation-bug.patch
>
> 0001 and 0003 are prep patches. 0002 and 0004 are the fixes.
>
> This patchset is on top of block/for-linus a322baad1003
> ("block/blk-cgroup.c: free per-blkcg data when freeing the blkcg") and
> available in the following git branch.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-blkcg-cpd-fixes
>
> diffstat follows, thanks.
Applied, thanks Tejun.
--
Jens Axboe
prev parent reply other threads:[~2015-07-10 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 20:39 Tejun Heo
2015-07-09 20:39 ` [PATCH 1/4] blkcg: allow blkcg_pol_mutex to be grabbed from cgroup [file] methods Tejun Heo
2015-07-09 20:39 ` [PATCH 2/4] blkcg: blkcg_css_alloc() should grab blkcg_pol_mutex while iterating blkcg_policy[] Tejun Heo
2015-07-09 20:39 ` [PATCH 3/4] blkcg: implement all_blkcgs list Tejun Heo
2015-07-09 20:39 ` [PATCH 4/4] blkcg: fix blkcg_policy_data allocation bug Tejun Heo
2015-07-10 14:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559FD686.2000306@kernel.dk \
--to=axboe@kernel.dk \
--cc=avanzini.arianna@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome