From: Helge Deller <deller@gmx.de>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Cc: liqiong@nfschina.com
Subject: Re: [PATCH -next] parisc: ccio-dma: Add missing iounmap in error path in ccio_probe()
Date: Wed, 24 Aug 2022 21:20:50 +0200 [thread overview]
Message-ID: <559e9805-3e38-fa50-d3ce-5eee317832bf@gmx.de> (raw)
In-Reply-To: <20220824093657.3365027-1-yangyingliang@huawei.com>
On 8/24/22 11:36, Yang Yingliang wrote:
> Add missing iounmap() before return from ccio_probe(), if ccio_init_resources()
> fails.
>
> Fixes: d46c742f827f ("parisc: ccio-dma: Handle kmalloc failure in ccio_init_resources()")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
applied.
Thanks!
Helge
> ---
> drivers/parisc/ccio-dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
> index f223afe47d10..a66386043aa6 100644
> --- a/drivers/parisc/ccio-dma.c
> +++ b/drivers/parisc/ccio-dma.c
> @@ -1546,6 +1546,7 @@ static int __init ccio_probe(struct parisc_device *dev)
> }
> ccio_ioc_init(ioc);
> if (ccio_init_resources(ioc)) {
> + iounmap(ioc->ioc_regs);
> kfree(ioc);
> return -ENOMEM;
> }
prev parent reply other threads:[~2022-08-24 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 9:36 Yang Yingliang
2022-08-24 19:20 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559e9805-3e38-fa50-d3ce-5eee317832bf@gmx.de \
--to=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®