From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C1119C566 for ; Tue, 7 Jan 2025 17:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736269337; cv=none; b=XTV5KqsnsoqDlTlLaKFHtkGVpg0I3nUkprrwlwy1jt4ooJyWS6S/ti2Kh6/wLDbv8sFu9qsy9/6WjSt/zt3maysOZURiLQ9fNcyWQISTeNxo+IJbmrYAJwUkCL1TQWFmonhV47WvsKoNWkfc2hXjCLWv6t/SlRb+6R2Fkh5kGVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736269337; c=relaxed/simple; bh=OfteFQQECn/V18Ivv4qEgx+94RgZYg/Veo8CfnZIOu4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QL/iOJDSjoS5Lr69cPwRI4UYWgOHZwm0p94S1ttFkz1W3dDIFkheaH6kBvqDc+hSjCXC7huYXW2tdz9NQP9xEvPm3bAeTO0emeZNawllFpObxV4oDqh5x2fZ8cBWK6z/TSMZAjRE+nq1LywsHT/QrIocZPZM6sjkieV1OdHpEEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PSYjOM+X; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PSYjOM+X" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736269334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ml+i5Y031koGxlGfy9NVkgnxHVhu74Le2+yCtHwQa/c=; b=PSYjOM+X4zO7m8+ol8U7yqZnsNP+NJ8kAY9xDLtFGsKfREC64Ls1P/ygAfUFT8z34DzhwI 3u6zKHloHnmKiJqdm5E7b2bRAC1gN0lrIXH9dUIJgWblyuWkPNQCnE8EEY0XRlXIs9Lz6M 5ATwZNjf6cR+OBXFm1ynetP13MKcKlg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649--Y5eoP_POKC3jsYx4ziilQ-1; Tue, 07 Jan 2025 12:02:13 -0500 X-MC-Unique: -Y5eoP_POKC3jsYx4ziilQ-1 X-Mimecast-MFC-AGG-ID: -Y5eoP_POKC3jsYx4ziilQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-436723bf7ffso102868075e9.3 for ; Tue, 07 Jan 2025 09:02:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736269332; x=1736874132; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ml+i5Y031koGxlGfy9NVkgnxHVhu74Le2+yCtHwQa/c=; b=R/fZHiVr2Fd6yw8/gXkwxIQCO3rmkI07LP3ydEevHDKZyW6jE0dL/DRXrO0dDDPk14 HR2543D3Qhoq1pCCcxuRtOCECG9BQ3iXFc/eWYtiK77yXloJt/hShk4xHyVlF0N0IMyl 3sFwD3BT6we1fnbJJjaQFfVuuDHaGHzM4ArGG7x2mrjsc3I6DgQsQXjGHTC/vOHIcF3b IVY/ldbWD0jCd8RJDOoTIH5BWMaRfj6AtBR/aveJ+Xr8224YlWBn+tQ9dRePM2Cs0t7B oCTAKZCcIuHsHtsqr3+UrTmlOHKwR/WNROYnpIs3HkbPM1xu3zJBUrWGC+YSD4dEfmFq 3lYg== X-Forwarded-Encrypted: i=1; AJvYcCWdBVu5C8flGyZwXMAkuh7tt5fXWFfMMV1HDm41ficKNA08Fy9yixZjJRxpY83OZIC6yWHamagIRonOc6k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3NLu9NX3SD0vNyYPqGvGzFPk4GvcQsZKZUNbDV/0ofaC1kzFV noNsYCId3RzMHwFYcL/5hymYN5NGIPU8EIT+8/PWtYaBkOXaUm0bVrQ8CERNGlhWlDgau5DH5z2 VHt8a29hCbiH+t6JYZqza8kX4SosTZGyL3jgEyTHPaOMfoUXbKucwqUMwVWikuQ== X-Gm-Gg: ASbGncv1QGJdj4YivQwBQRXzGLEQqE51YwxyWe/+apdjIrwWFNvYo/bHXAHsE+v/O+q FpzqZ+dHSYVU+DKy0EvEXzLaoAOaJHKfC1pv+gaCoYrNWdO9GDB/ZQux/BchKPGc5V2fzV9KnKw 7gids3dCfWx/ItcbYTbrQ5Xmg66HKYLh6fksLmBadUnn/+8HoX8Cs3p/YFu7kMrR0wEUa3cLLre EUGXnIFavbncLawvZ1RiXO3zisMqxcwb0UFCyeGw8gXHrRBcyYavZ+T+XG7+r0nTB703OLETmgx ycncKdAEAN5ziVHB2B1LfMYRJc2wCjQ4LG9GsqsZLsuz9+rS7X3wYcyeFbD4pu8zVtWWOl0ebHw tNGOkxmiL X-Received: by 2002:a05:600c:3b13:b0:436:488f:4f5 with SMTP id 5b1f17b1804b1-4366864420bmr544002835e9.19.1736269331132; Tue, 07 Jan 2025 09:02:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IH831uLh5Mj7aUB/xio+HRhWWKfF4N6mD9hkgVX9Y3KYGbbPzwcIxk+HQL/Ghab3kVNIgPl3w== X-Received: by 2002:a05:600c:3b13:b0:436:488f:4f5 with SMTP id 5b1f17b1804b1-4366864420bmr543998825e9.19.1736269328687; Tue, 07 Jan 2025 09:02:08 -0800 (PST) Received: from ?IPV6:2003:cb:c719:1700:56dc:6a88:b509:d3f3? (p200300cbc719170056dc6a88b509d3f3.dip0.t-ipconnect.de. [2003:cb:c719:1700:56dc:6a88:b509:d3f3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436611ea47asm603054135e9.4.2025.01.07.09.02.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 09:02:07 -0800 (PST) Message-ID: <559ea5ca-fea2-4a0a-a099-23e2d972f6e6@redhat.com> Date: Tue, 7 Jan 2025 18:02:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v1] mm/hugetlb_vmemmap: fix memory loads ordering To: Matthew Wilcox Cc: Yu Zhao , Andrew Morton , Mateusz Guzik , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Will Deacon References: <20250107043505.351925-1-yuzhao@google.com> <85ea0bc9-0892-489d-b42b-430ff8a1f368@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.01.25 17:35, Matthew Wilcox wrote: > On Tue, Jan 07, 2025 at 09:49:18AM +0100, David Hildenbrand wrote: >>> +++ b/include/linux/page-flags.h >>> @@ -212,7 +212,7 @@ static __always_inline const struct page *page_fixed_fake_head(const struct page >>> * cold cacheline in some cases. >>> */ >>> if (IS_ALIGNED((unsigned long)page, PAGE_SIZE) && >>> - test_bit(PG_head, &page->flags)) { >>> + test_bit_acquire(PG_head, &page->flags)) { >> >> This change will affect all page_fixed_fake_head() users, like ordinary >> PageTail even on !hugetlb. > > I've been looking at the callers of PageTail() because it's going to > be a bit of a weird thing to be checking in the separate-page-and-folio > world. Obviously we can implement it, but there's a bit of a "But why > would you want to ask that question" question. > > Most current occurrences of PageTail() are in assertions of one form or > another. Fair enough, not performance critical. > > make_device_exclusive_range() is a little weird; looks like it's trying > to make sure that each folio is only made exclusive once, and ignore any > partial folios which overlap the start of the area. I could have sworn we only support small folios here, but looks like we do support large folios. IIUC, there is no way to identify reliably "this folio is device exclusive", the only hint is "no mappings". The following might do: diff --git a/mm/rmap.c b/mm/rmap.c index c6c4d4ea29a7e..1424d0a351a86 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -2543,7 +2543,13 @@ int make_device_exclusive_range(struct mm_struct *mm, unsigned long start, for (i = 0; i < npages; i++, start += PAGE_SIZE) { struct folio *folio = page_folio(pages[i]); - if (PageTail(pages[i]) || !folio_trylock(folio)) { + + /* + * If there are no mappings, either the folio is actually + * unmapped or only device-exclusive swap entries point at + * this folio. + */ + if (!folio_mapped(folio) || !folio_trylock(folio)) { folio_put(folio); pages[i] = NULL; continue; > > damon_get_folio() wants to fail for tail pages. Fair enough. > > split_huge_pages_all() is debug code. > > page_idle_get_folio() is like damon. > > That's it. We don't seem to have any PageTail() callers in critical > code any more. Ah, you're right. Interestingly, PageTransTail() is even unused? -- Cheers, David / dhildenb