From: Alexei Starovoitov <ast@plumgrid.com>
To: He Kuang <hekuang@huawei.com>,
rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com,
acme@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
namhyung@kernel.org, jolsa@kernel.org
Cc: wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v5 0/3] Make eBPF programs output data to perf
Date: Mon, 13 Jul 2015 20:10:29 -0700 [thread overview]
Message-ID: <55A47DA5.9080808@plumgrid.com> (raw)
In-Reply-To: <1436839171-31527-1-git-send-email-hekuang@huawei.com>
On 7/13/15 6:59 PM, He Kuang wrote:
> This version we output bpf trace events in a hex array, the results
> for three u64 integers in previous sample changed to this:
>
> dd 1042 [000] 1296.122951: bpf:bpf_output_data: 7a ca aa c6 2d 01 00
> 00 95 87 ec ca 2d 01 00 00 1b bd 41 04 00 00 00 00
typo in the above. It's not 3 u64 integers, but variable number of u8.
Whole thing looks good.
I've acked patch 3.
Hopefully Steven can review patches 1 and 2.
next prev parent reply other threads:[~2015-07-14 3:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 1:59 He Kuang
2015-07-14 1:59 ` [RFC PATCH v5 1/3] tracing/events: Fix wrong sample output by storing array length instead of size He Kuang
2015-07-14 1:59 ` [RFC PATCH v5 2/3] tools lib traceevent: Add function to get dynamic arrays length He Kuang
2015-07-17 3:36 ` Wangnan (F)
2015-07-17 14:36 ` Steven Rostedt
2015-07-17 14:43 ` pi3orama
2015-07-14 1:59 ` [RFC PATCH v5 3/3] bpf: Introduce function for outputing trace event data He Kuang
2015-07-14 3:08 ` Alexei Starovoitov
2015-07-14 3:10 ` Alexei Starovoitov [this message]
2015-07-14 13:35 ` [RFC PATCH v5 0/3] Make eBPF programs output data to perf Steven Rostedt
2015-07-17 2:31 ` He Kuang
2015-07-17 2:38 ` Steven Rostedt
2015-07-17 2:39 ` Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A47DA5.9080808@plumgrid.com \
--to=ast@plumgrid.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®